Review comments

Author: schmidt-sebastian

packages/firestore/src/local/indexeddb_schema.ts

@@ -67,8 +67,10 @@ export function createOrUpgradeDb(
   }
 
   if (fromVersion < 3 && toVersion >= 3) {
-    createClientMetadataStore(db);
-    createTargetChangeStore(db);
+    p = p.next(() => {
+      createClientMetadataStore(db);
+      createTargetChangeStore(db);
+    });
   }
   return p;
 }
@@ -645,7 +647,7 @@ export const V1_STORES = [
 // Visible for testing
 export const V2_STORES = V1_STORES;
 
-const V3_STORES = [...V2_STORES, DbClientMetadata.store, DbTargetChange.store];
+export const V3_STORES = [...V2_STORES, DbClientMetadata.store, DbTargetChange.store];
 
 /**
  * The list of all default IndexedDB stores used throughout the SDK. This is

packages/firestore/test/unit/local/indexeddb_schema.test.ts

@@ -17,13 +17,13 @@
 import { expect } from 'chai';
 import { IndexedDbPersistence } from '../../../src/local/indexeddb_persistence';
 import {
-  ALL_STORES,
   createOrUpgradeDb,
   DbTarget,
   DbTargetGlobal,
   DbTargetGlobalKey,
   V1_STORES,
-  V2_STORES
+  V2_STORES,
+  V3_STORES
 } from '../../../src/local/indexeddb_schema';
 import { SimpleDb, SimpleDbTransaction } from '../../../src/local/simple_db';
 import { PersistencePromise } from '../../../src/local/persistence_promise';
@@ -113,7 +113,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
   it('can install schema version 3', () => {
     return withDb(3, async db => {
       expect(db.version).to.be.equal(3);
-      expect(getAllObjectStores(db)).to.have.members(ALL_STORES);
+      expect(getAllObjectStores(db)).to.have.members(V3_STORES);
     });
   });
 
@@ -146,7 +146,7 @@ describe('IndexedDbSchema: createOrUpgradeDb', () => {
     return withDb(2, async () => {}).then(() =>
       withDb(3, async db => {
         expect(db.version).to.be.equal(3);
-        expect(getAllObjectStores(db)).to.have.members(ALL_STORES);
+        expect(getAllObjectStores(db)).to.have.members(V3_STORES);
       })
     );
   });