Address PR comments

Author: hsubox76

packages/app-check/src/api.test.ts

@@ -114,8 +114,10 @@ describe('api', () => {
     it('getToken() throws errors returned with token', async () => {
       const app = getFakeApp({ automaticDataCollectionEnabled: true });
       const fakePlatformLoggingProvider = getFakePlatformLoggingProvider();
+      // If getToken() errors, it returns a dummy token with an error field
+      // instead of throwing.
       stub(internalApi, 'getToken').resolves({
-        token: 'a-token-string',
+        token: 'a-dummy-token',
         error: Error('there was an error')
       });
       await expect(

packages/app-check/src/internal-api.ts

@@ -202,11 +202,7 @@ export function addTokenListener(
      * invoke the listener with the valid token, then start the token refresher
      */
     if (!newState.tokenRefresher) {
-      const tokenRefresher = createTokenRefresher(
-        app,
-        platformLoggerProvider,
-        onError
-      );
+      const tokenRefresher = createTokenRefresher(app, platformLoggerProvider);
       newState.tokenRefresher = tokenRefresher;
     }
 
@@ -258,8 +254,7 @@ export function removeTokenListener(
 
 function createTokenRefresher(
   app: FirebaseApp,
-  platformLoggerProvider: Provider<'platform-logger'>,
-  onError?: (error: Error) => void
+  platformLoggerProvider: Provider<'platform-logger'>
 ): Refresher {
   return new Refresher(
     // Keep in mind when this fails for any reason other than the ones
@@ -277,11 +272,7 @@ function createTokenRefresher(
 
       // getToken() always resolves. In case the result has an error field defined, it means the operation failed, and we should retry.
       if (result.error) {
-        if (onError) {
-          onError(result.error);
-        } else {
-          throw result.error;
-        }
+        throw result.error;
       }
     },
     () => {