Cleanup

Author: schmidt-sebastian

packages/firestore/rollup.config.js

@@ -39,7 +39,7 @@ import {
 // - In-memory Browser builds that support persistence in ES5 CJS and ES5 ESM
 //   formats and ES2017 in ESM format.
 // - A NodeJS build that supports persistence (to be used with an IndexedDb
-//  shim)
+//   shim)
 // - A in-memory only NodeJS build
 //
 // The in-memory builds are roughly 130 KB smaller, but throw an exception
@@ -61,7 +61,7 @@ function resolveBrowserExterns(id) {
   return browserDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
 }
 
-/** Resolves the external dependencies for the NOde build. */
+/** Resolves the external dependencies for the Node build. */
 function resolveNodeExterns(id) {
   return nodeDeps.some(dep => id === dep || id.startsWith(`${dep}/`));
 }
@@ -96,7 +96,6 @@ export function resolveMemoryExterns(deps, externsId, referencedBy) {
   return deps.some(dep => externsId === dep || externsId.startsWith(`${dep}/`));
 }
 
-
 const es5BuildPlugins = [
   typescriptPlugin({
     typescript,

packages/firestore/src/api/database.ts

@@ -317,8 +317,8 @@ export class Firestore implements firestore.FirebaseFirestore, FirebaseService {
   readonly _dataConverter: UserDataConverter;
 
   // Note: We are using `MemoryPersistenceProvider` as a default
-  // PersistenceProvider to not change the constructor in the existing console
-  // build.
+  // PersistenceProvider to ensure backwards compatibility with the format
+  // expected by the console build.
   constructor(
     databaseIdOrApp: FirestoreDatabase | FirebaseApp,
     authProvider: Provider<FirebaseAuthInternalName>,

packages/firestore/src/core/firestore_client.ts

@@ -216,7 +216,7 @@ export class FirestoreClient {
    * the persistenceResult and falls back on memory-only persistence.
    *
    * @param persistenceProvider The provider that provides either IndexedDb or
-   *     memory-backed persistence.
+   *     memory-backed persistence
    * @param persistenceSettings Settings object to configure offline persistence
    * @param user The initial user
    * @param persistenceResult A deferred result indicating the user-visible

packages/installations/src/util/errors.ts

@@ -45,7 +45,7 @@ interface ErrorParams {
   };
   [ErrorCode.REQUEST_FAILED]: {
     requestName: string;
-    [index: string]: string | number; // to make Typescript 3.8 happy
+    [index: string] : string | number; // to make Typescript 3.8 happy
   } & ServerErrorData;
 }