Skip to content

Commit dce697c

Browse files
committed
Update internal get analytics id
1 parent 93ed844 commit dce697c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

packages/analytics/src/api.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -180,10 +180,11 @@ export async function getGoogleAnalyticsClientId(
180180
analyticsInstance: Analytics
181181
): Promise<string> {
182182
analyticsInstance = getModularInstance(analyticsInstance);
183-
return internalGetGoogleAnalyticsClientId(
183+
const clientId = await internalGetGoogleAnalyticsClientId(
184184
wrappedGtagFunction,
185-
initializationPromisesMap[analyticsInstance.app.options.measurementId!]
185+
analyticsInstance.app.options.measurementId!
186186
);
187+
return clientId;
187188
}
188189

189190
/**

packages/analytics/src/functions.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ describe('FirebaseAnalytics methods', () => {
252252
): void {
253253
callBackStub('');
254254
} as Gtag,
255-
fakeInitializationPromise
255+
fakeMeasurementId
256256
)
257257
).to.be.rejectedWith(AnalyticsError.NO_CLIENT_ID);
258258
});
@@ -267,7 +267,7 @@ describe('FirebaseAnalytics methods', () => {
267267
): void {
268268
callBackStub(CLIENT_ID);
269269
} as Gtag,
270-
fakeInitializationPromise
270+
fakeMeasurementId
271271
);
272272
expect(id).to.equal(CLIENT_ID);
273273
});

packages/analytics/src/functions.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -148,9 +148,8 @@ export async function setUserProperties(
148148
*/
149149
export async function internalGetGoogleAnalyticsClientId(
150150
gtagFunction: Gtag,
151-
initializationPromise: Promise<string>
151+
measurementId: string
152152
): Promise<string> {
153-
const measurementId = await initializationPromise;
154153
return new Promise((resolve, reject) => {
155154
gtagFunction(
156155
GtagCommand.GET,

0 commit comments

Comments
 (0)