Skip to content

Commit dc3794a

Browse files
authored
VinF Hybrid Inference: remove default expected input types (#8974)
1 parent 6c60de5 commit dc3794a

File tree

2 files changed

+10
-24
lines changed

2 files changed

+10
-24
lines changed

packages/vertexai/src/methods/chrome-adapter.test.ts

+9-16
Original file line numberDiff line numberDiff line change
@@ -122,13 +122,14 @@ describe('ChromeAdapter', () => {
122122
const createStub = stub(languageModelProvider, 'create').resolves(
123123
{} as LanguageModel
124124
);
125-
const adapter = new ChromeAdapter(
126-
languageModelProvider,
127-
'prefer_on_device'
128-
);
129125
const expectedOnDeviceParams = {
130126
expectedInputs: [{ type: 'image' }]
131127
} as LanguageModelCreateOptions;
128+
const adapter = new ChromeAdapter(
129+
languageModelProvider,
130+
'prefer_on_device',
131+
expectedOnDeviceParams
132+
);
132133
expect(
133134
await adapter.isAvailable({
134135
contents: [{ role: 'user', parts: [{ text: 'hi' }] }]
@@ -221,17 +222,14 @@ describe('ChromeAdapter', () => {
221222
);
222223
const promptOutput = 'hi';
223224
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
224-
const onDeviceParams = {
225-
systemPrompt: 'be yourself'
226-
} as LanguageModelCreateOptions;
227225
const expectedOnDeviceParams = {
228226
systemPrompt: 'be yourself',
229227
expectedInputs: [{ type: 'image' }]
230228
} as LanguageModelCreateOptions;
231229
const adapter = new ChromeAdapter(
232230
languageModelProvider,
233231
'prefer_on_device',
234-
onDeviceParams
232+
expectedOnDeviceParams
235233
);
236234
const request = {
237235
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
@@ -270,17 +268,14 @@ describe('ChromeAdapter', () => {
270268
);
271269
const promptOutput = 'hi';
272270
const promptStub = stub(languageModel, 'prompt').resolves(promptOutput);
273-
const onDeviceParams = {
274-
systemPrompt: 'be yourself'
275-
} as LanguageModelCreateOptions;
276271
const expectedOnDeviceParams = {
277272
systemPrompt: 'be yourself',
278273
expectedInputs: [{ type: 'image' }]
279274
} as LanguageModelCreateOptions;
280275
const adapter = new ChromeAdapter(
281276
languageModelProvider,
282277
'prefer_on_device',
283-
onDeviceParams
278+
expectedOnDeviceParams
284279
);
285280
const request = {
286281
contents: [
@@ -379,14 +374,13 @@ describe('ChromeAdapter', () => {
379374
}
380375
})
381376
);
382-
const onDeviceParams = {} as LanguageModelCreateOptions;
383377
const expectedOnDeviceParams = {
384378
expectedInputs: [{ type: 'image' }]
385379
} as LanguageModelCreateOptions;
386380
const adapter = new ChromeAdapter(
387381
languageModelProvider,
388382
'prefer_on_device',
389-
onDeviceParams
383+
expectedOnDeviceParams
390384
);
391385
const request = {
392386
contents: [{ role: 'user', parts: [{ text: 'anything' }] }]
@@ -423,14 +417,13 @@ describe('ChromeAdapter', () => {
423417
}
424418
})
425419
);
426-
const onDeviceParams = {} as LanguageModelCreateOptions;
427420
const expectedOnDeviceParams = {
428421
expectedInputs: [{ type: 'image' }]
429422
} as LanguageModelCreateOptions;
430423
const adapter = new ChromeAdapter(
431424
languageModelProvider,
432425
'prefer_on_device',
433-
onDeviceParams
426+
expectedOnDeviceParams
434427
);
435428
const request = {
436429
contents: [

packages/vertexai/src/methods/chrome-adapter.ts

+1-8
Original file line numberDiff line numberDiff line change
@@ -42,9 +42,7 @@ export class ChromeAdapter {
4242
private languageModelProvider?: LanguageModel,
4343
private mode?: InferenceMode,
4444
private onDeviceParams: LanguageModelCreateOptions = {}
45-
) {
46-
this.addImageTypeAsExpectedInput();
47-
}
45+
) {}
4846

4947
/**
5048
* Checks if a given request can be made on-device.
@@ -238,11 +236,6 @@ export class ChromeAdapter {
238236
return newSession;
239237
}
240238

241-
private addImageTypeAsExpectedInput(): void {
242-
// Defaults to support image inputs for convenience.
243-
this.onDeviceParams.expectedInputs ??= [{ type: 'image' }];
244-
}
245-
246239
/**
247240
* Formats string returned by Chrome as a {@link Response} returned by Vertex.
248241
*/

0 commit comments

Comments
 (0)