Making the linter happy

Author: rafikhan

packages/firebase/index.d.ts

@@ -7879,7 +7879,7 @@ declare namespace firebase.firestore {
      * buffer traffic indefinitely. Use of this option will cause some
      * performance degradation though.
      *
-     * This setting cannot be used with experimentalAutodetectLongPolling and
+     * This setting cannot be used with experimentalAutoDetectLongPolling and
      * may be removed in a future release. If you find yourself using it to
      * work around a specific network reliability issue, please tell us about
      * it in https://github.com/firebase/firebase-js-sdk/issues/1674.
@@ -7898,7 +7898,7 @@ declare namespace firebase.firestore {
      *
      * @webonly
      */
-    experimentalAutodetectLongPolling?: boolean;
+    experimentalAutoDetectLongPolling?: boolean;
 
     /**
      * Whether to skip nested properties that are set to `undefined` during

packages/firestore-types/index.d.ts

@@ -29,7 +29,7 @@ export interface Settings {
   timestampsInSnapshots?: boolean;
   cacheSizeBytes?: number;
   experimentalForceLongPolling?: boolean;
-  experimentalAutodetectLongPolling?: boolean;
+  experimentalAutoDetectLongPolling?: boolean;
   ignoreUndefinedProperties?: boolean;
   merge?: boolean;
 }

packages/firestore/exp/src/api/database.ts

@@ -116,7 +116,7 @@ export class Firestore
       settings.host ?? DEFAULT_HOST,
       settings.ssl ?? DEFAULT_SSL,
       /* forceLongPolling= */ false,
-      /* forceAutodetectLongPolling= */ false
+      /* forceAutoDetectLongPolling= */ false
     );
     return {
       asyncQueue: this._queue,

packages/firestore/lite/src/api/components.ts

@@ -60,7 +60,7 @@ export function getDatastore(firestore: Firestore): Datastore {
       settings.host ?? DEFAULT_HOST,
       settings.ssl ?? DEFAULT_SSL,
       /* forceLongPolling= */ false,
-      /* forceAutodetectLongPolling= */ false
+      /* forceAutoDetectLongPolling= */ false
     );
 
     const connection = newConnection(databaseInfo);

packages/firestore/src/api/database.ts

@@ -193,7 +193,7 @@ class FirestoreSettings {
 
   readonly experimentalForceLongPolling: boolean;
 
-  readonly experimentalAutodetectLongPolling: boolean;
+  readonly experimentalAutoDetectLongPolling: boolean;
 
   readonly ignoreUndefinedProperties: boolean;
 
@@ -225,7 +225,7 @@ class FirestoreSettings {
       'timestampsInSnapshots',
       'cacheSizeBytes',
       'experimentalForceLongPolling',
-      'experimentalAutodetectLongPolling',
+      'experimentalAutoDetectLongPolling',
       'ignoreUndefinedProperties'
     ]);
 
@@ -303,18 +303,18 @@ class FirestoreSettings {
     validateNamedOptionalType(
       'settings',
       'boolean',
-      'experimentalAutodetectLongPolling',
-      settings.experimentalAutodetectLongPolling
+      'experimentalAutoDetectLongPolling',
+      settings.experimentalAutoDetectLongPolling
     );
-    this.experimentalAutodetectLongPolling =
-      settings.experimentalAutodetectLongPolling ??
+    this.experimentalAutoDetectLongPolling =
+      settings.experimentalAutoDetectLongPolling ??
       DEFAULT_FORCE_AUTODETECT_LONG_POLLING;
 
     validateIsNotUsedTogether(
       'experimentalForceLongPolling',
       settings.experimentalForceLongPolling,
-      'experimentalAutodetectLongPolling',
-      settings.experimentalAutodetectLongPolling
+      'experimentalAutoDetectLongPolling',
+      settings.experimentalAutoDetectLongPolling
     );
   }
 
@@ -327,8 +327,8 @@ class FirestoreSettings {
       this.cacheSizeBytes === other.cacheSizeBytes &&
       this.experimentalForceLongPolling ===
         other.experimentalForceLongPolling &&
-      this.experimentalAutodetectLongPolling ===
-        other.experimentalAutodetectLongPolling &&
+      this.experimentalAutoDetectLongPolling ===
+        other.experimentalAutoDetectLongPolling &&
       this.ignoreUndefinedProperties === other.ignoreUndefinedProperties
     );
   }
@@ -577,7 +577,7 @@ export class Firestore implements PublicFirestore, FirebaseService {
       this._settings.host,
       this._settings.ssl,
       this._settings.experimentalForceLongPolling,
-      this._settings.experimentalAutodetectLongPolling
+      this._settings.experimentalAutoDetectLongPolling
     );
   }
 

packages/firestore/src/core/database_info.ts

@@ -29,7 +29,7 @@ export class DatabaseInfo {
    * @param ssl Whether to use SSL when connecting.
    * @param forceLongPolling Whether to use the forceLongPolling option
    * when using WebChannel as the network transport.
-   * @param autodetectLongPolling Whether to use the autodetectLongPolling
+   * @param autoDetectLongPolling Whether to use the autoDetectLongPolling
    * option when using WebChannel as the network transport.
    */
   constructor(
@@ -38,7 +38,7 @@ export class DatabaseInfo {
     readonly host: string,
     readonly ssl: boolean,
     readonly forceLongPolling: boolean,
-    readonly autodetectLongPolling: boolean
+    readonly autoDetectLongPolling: boolean
   ) {}
 }
 

packages/firestore/src/platform/browser/webchannel_connection.ts

@@ -57,12 +57,12 @@ const XHR_TIMEOUT_SECS = 15;
 
 export class WebChannelConnection extends RestConnection {
   private readonly forceLongPolling: boolean;
-  private readonly autodetectLongPolling: boolean;
+  private readonly autoDetectLongPolling: boolean;
 
   constructor(info: DatabaseInfo) {
     super(info);
     this.forceLongPolling = info.forceLongPolling;
-    this.autodetectLongPolling = info.autodetectLongPolling;
+    this.autoDetectLongPolling = info.autoDetectLongPolling;
   }
 
   protected performRPCRequest<Req, Resp>(
@@ -186,7 +186,7 @@ export class WebChannelConnection extends RestConnection {
         forwardChannelRequestTimeoutMs: 10 * 60 * 1000
       },
       forceLongPolling: this.forceLongPolling,
-      detectBufferingProxy: this.autodetectLongPolling
+      detectBufferingProxy: this.autoDetectLongPolling
     };
 
     this.modifyHeadersForRequest(request.initMessageHeaders!, token);

packages/firestore/test/integration/util/internal_helpers.ts

@@ -45,7 +45,7 @@ export function getDefaultDatabaseInfo(): DatabaseInfo {
     DEFAULT_SETTINGS.host!,
     !!DEFAULT_SETTINGS.ssl,
     !!DEFAULT_SETTINGS.experimentalForceLongPolling,
-    !!DEFAULT_SETTINGS.experimentalAutodetectLongPolling
+    !!DEFAULT_SETTINGS.experimentalAutoDetectLongPolling
   );
 }
 

packages/firestore/test/integration/util/settings.ts

@@ -34,12 +34,14 @@ export const USE_EMULATOR = !!EMULATOR_PORT;
 
 const EMULATOR_FIRESTORE_SETTING = {
   host: `localhost:${EMULATOR_PORT}`,
-  ssl: false
+  ssl: false,
+  experimentalAutoDetectLongPolling: true
 };
 
 const PROD_FIRESTORE_SETTING = {
   host: 'firestore.googleapis.com',
-  ssl: true
+  ssl: true,
+  experimentalAutoDetectLongPolling: true
 };
 
 export const DEFAULT_SETTINGS = getDefaultSettings();

packages/firestore/test/unit/remote/rest_connection.test.ts

@@ -60,7 +60,8 @@ describe('RestConnection', () => {
     'persistenceKey',
     'example.com',
     /*ssl=*/ false,
-    /*forceLongPolling=*/ false
+    /*forceLongPolling=*/ false,
+    /*autoDetectLongPolling=*/ false
   );
   const connection = new TestRestConnection(testDatabaseInfo);
 

packages/firestore/test/unit/specs/spec_test_runner.ts

@@ -232,7 +232,7 @@ abstract class TestRunner {
       'host',
       /*ssl=*/ false,
       /*forceLongPolling=*/ false,
-      /*autodetectLongPolling=*/ true
+      /*autoDetectLongPolling=*/ true
     );
 
     // TODO(mrschmidt): During client startup in `firestore_client`, we block