Skip to content

Commit d9bf41c

Browse files
Run Firestore Integration tests against mangled sources (#2533)
1 parent 5fb352a commit d9bf41c

File tree

4 files changed

+13
-12
lines changed

4 files changed

+13
-12
lines changed

integration/firestore/gulpfile.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function copyTests() {
3737
const firebaseAppSdk = 'firebase/app/dist/index.esm.js';
3838
const firebaseFirestoreSdk = resolve(
3939
__dirname,
40-
'../../packages/firestore/dist/index.esm.js'
40+
'../../packages/firestore/dist/index.esm.min.js'
4141
);
4242
return gulp
4343
.src(

packages/firestore/externs.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
"packages/webchannel-wrapper/src/index.d.ts",
2222
"packages/util/dist/src/environment.d.ts",
2323
"packages/firestore/src/protos/firestore_proto_api.d.ts",
24+
"packages/firestore/dist/lib/src/util/error.d.ts",
2425
"packages/firestore/dist/lib/src/local/indexeddb_schema.d.ts",
2526
"packages/firestore/dist/lib/src/local/shared_client_state_schema.d.ts"
2627
]

packages/firestore/test/integration/api/database.test.ts

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1106,17 +1106,6 @@ apiDescribe('Database', (persistence: boolean) => {
11061106
});
11071107
});
11081108

1109-
it('app delete leads to instance termination', async () => {
1110-
await withTestDoc(persistence, async docRef => {
1111-
await docRef.set({ foo: 'bar' });
1112-
const app = docRef.firestore.app;
1113-
await app.delete();
1114-
1115-
// eslint-disable-next-line @typescript-eslint/no-explicit-any
1116-
expect((docRef.firestore as any)._isTerminated).to.be.true;
1117-
});
1118-
});
1119-
11201109
it('new operation after termination should throw', async () => {
11211110
await withTestDoc(persistence, async docRef => {
11221111
const firestore = docRef.firestore;

packages/firestore/test/integration/api_internal/database.test.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,4 +68,15 @@ apiDescribe('Database (with internal API)', (persistence: boolean) => {
6868
}
6969
);
7070
});
71+
72+
it('app delete leads to instance termination', async () => {
73+
await withTestDoc(persistence, async docRef => {
74+
await docRef.set({ foo: 'bar' });
75+
const app = docRef.firestore.app;
76+
await app.delete();
77+
78+
// eslint-disable-next-line @typescript-eslint/no-explicit-any
79+
expect((docRef.firestore as any)._isTerminated).to.be.true;
80+
});
81+
});
7182
});

0 commit comments

Comments
 (0)