PR feedback

Author: sam-gc

packages-exp/auth-exp/src/core/user/account_info.test.ts

@@ -22,7 +22,6 @@ import * as sinonChai from 'sinon-chai';
 
 import { ProviderId, UserInfo } from '@firebase/auth-types-exp';
 
-// import { UserInfo } from '@firebase/auth-types-exp';
 import { mockEndpoint } from '../../../test/api/helper';
 import { TestAuth, testAuth, testUser } from '../../../test/mock_auth';
 import * as fetch from '../../../test/mock_fetch';

packages-exp/auth-exp/src/core/user/reload.ts

@@ -17,10 +17,7 @@
 
 import * as externs from '@firebase/auth-types-exp';
 
-import {
-  getAccountInfo,
-  ProviderUserInfo
-} from '../../api/account_management/account';
+import { getAccountInfo, ProviderUserInfo } from '../../api/account_management/account';
 import { User } from '../../model/user';
 import { assert } from '../util/assert';
 

packages-exp/auth-exp/src/model/user.d.ts

@@ -21,7 +21,7 @@ import { PersistedBlob } from '../core/persistence';
 import { Auth } from './auth';
 import { IdTokenResponse } from './id_token';
 
-type ModifiableUserInfo = {
+type MutableUserInfo = {
   -readonly [K in keyof externs.UserInfo]: externs.UserInfo[K];
 };
 
@@ -37,7 +37,7 @@ export interface User extends externs.User {
   refreshToken: string;
   emailVerified: boolean;
   tenantId: string | null;
-  providerData: ModifiableUserInfo[];
+  providerData: MutableUserInfo[];
   metadata: externs.UserMetadata;
   _updateTokensIfNecessary(response: IdTokenResponse): boolean;