Skip to content

Commit d7c6d62

Browse files
authored
Fix to avoid false failures on changeset checker (#4012)
1 parent a74a1d1 commit d7c6d62

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/check-changeset.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,8 @@ jobs:
2424
id: check-changeset
2525
- name: Print changeset checker output
2626
run: echo "${{steps.check-changeset.outputs.CHANGESET_ERROR_MESSAGE}}"
27+
- name: Print blocking failure status
28+
run: echo "${{steps.check-changeset.outputs.BLOCKING_FAILURE}}"
2729
- name: Find Comment
2830
uses: peter-evans/find-comment@v1
2931
id: fc
@@ -59,5 +61,5 @@ jobs:
5961
- No changeset formatting errors detected.
6062
# Don't want it to throw before editing the comment.
6163
- name: Fail if checker script logged a blocking failure
62-
if: ${{steps.check-changeset.outputs.BLOCKING_FAILURE}}
64+
if: ${{steps.check-changeset.outputs.BLOCKING_FAILURE == 'true'}}
6365
run: exit 1

scripts/check_changeset.ts

+1
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ async function main() {
8787
const errors = [];
8888
try {
8989
await exec('yarn changeset status');
90+
console.log(`::set-output name=BLOCKING_FAILURE::false`);
9091
} catch (e) {
9192
const messageLines = e.message.replace(/🦋 error /g, '').split('\n');
9293
let formattedStatusError =

0 commit comments

Comments
 (0)