Merge branch 'master' into recaptcha

Author: chuanr

.changeset/config.json

@@ -21,7 +21,9 @@
     "firebase-repo-scripts-prune-dts"
   ],
   "___experimentalUnsafeOptions_WILL_CHANGE_IN_PATCH": {
-    "onlyUpdatePeerDependentsWhenOutOfRange": true,
-    "useCalculatedVersionForSnapshots": true
+    "onlyUpdatePeerDependentsWhenOutOfRange": true
+  },
+  "snapshot": {
+    "useCalculatedVersion": true
   }
 }

.changeset/cool-grapes-attend.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'firebase': patch
+---
+
+Internal refactor of platform-specific logic to create TextEncoder and TextDecoder objects.

.changeset/cool-seas-confess.md

@@ -0,0 +1,7 @@
+---
+'@firebase/firestore': patch
+'@firebase/util': patch
+'firebase': patch
+---
+
+Modify base64 decoding logic to throw on invalid input, rather than silently truncating it.

.changeset/large-lamps-reflect.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Refactoring the aggregation implementation to support future aggregate functions.

.changeset/large-lemons-relax.md

@@ -55,15 +55,14 @@ packages/storage-types @maneesht @tonyjhuang @firebase/jssdk-global-approvers
 # Messaging Code
 packages/messaging  @zwu52 @firebase/jssdk-global-approvers
 packages/messaging-compat  @zwu52 @firebase/jssdk-global-approvers
-packages/messaging-types @zwu52 @firebase/jssdk-global-approvers
 packages/messaging-interop-types @zwu52 @firebase/jssdk-global-approvers
 integration/messaging @zwu52 @firebase/jssdk-global-approvers
 
 # Auth Code
-packages/auth  @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-compat @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-types @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-interop-types @avolkovi @lisajian @sam-gc @yuchenshi @firebase/jssdk-global-approvers
+packages/auth @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-compat @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-types @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
+packages/auth-interop-types @lisajian @prameshj @renkelvin @sam-gc @firebase/jssdk-global-approvers
 
 # Testing Code
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers

.changeset/metal-goats-unite.md

@@ -47,6 +47,10 @@ jobs:
         working-directory: ./config
         env:
           FIREBASE_CLI_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
+      - name: Do modular build
+        run: yarn build:modular
+      - name: Do compat build
+        run: yarn build:compat
       - name: Run modular tests
         env:
           APP_CHECK_DEBUG_TOKEN: ${{ secrets.APP_CHECK_DEBUG_TOKEN }}

.changeset/moody-icons-repeat.md

@@ -18,7 +18,7 @@ jobs:
         run: |
           export VERSION_SCRIPT="const pkg = require('./packages/firebase/package.json'); console.log(pkg.version);"
           export VERSION=`node -e "${VERSION_SCRIPT}"`
-          echo "::set-output name=RELEASE_VERSION::$VERSION"
+          echo "RELEASE_VERSION=$VERSION" >> $GITHUB_OUTPUT
       - name: Echo version in shell
         run: |
           echo "Merging release ${{ steps.get-version.outputs.RELEASE_VERSION }}"

.changeset/popular-apples-peel.md

@@ -95,7 +95,7 @@ jobs:
       run: |
         VERSION_SCRIPT="const pkg = require('./packages/firebase/package.json'); console.log(pkg.version);"
         VERSION=`node -e "${VERSION_SCRIPT}"`
-        echo "::set-output name=BASE_VERSION::$VERSION"
+        echo "BASE_VERSION=$VERSION" >> $GITHUB_OUTPUT
     - name: Echo version in shell
       run: |
         echo "Base version: ${{ steps.get-version.outputs.BASE_VERSION }}"

.changeset/popular-items-hide.md

@@ -114,9 +114,9 @@ jobs:
       run: |
         VERSION_SCRIPT="const pkg = require('./packages/firebase/package.json'); console.log(pkg.version);"
         VERSION=`node -e "${VERSION_SCRIPT}"`
-        echo "::set-output name=STAGING_VERSION::$VERSION"
+        echo "STAGING_VERSION=$VERSION" >> $GITHUB_OUTPUT
         BASE_VERSION=$(echo $VERSION | cut -d "-" -f 1)
-        echo "::set-output name=BASE_VERSION::$BASE_VERSION"
+        echo "BASE_VERSION=$BASE_VERSION" >> $GITHUB_OUTPUT
     - name: Echo versions in shell
       run: |
         echo "Staging release ${{ steps.get-version.outputs.STAGING_VERSION }}"

.changeset/shy-dragons-fly.md

@@ -0,0 +1,41 @@
+name: Send Release Tweet
+
+on:
+  workflow_dispatch:
+    inputs:
+      version:
+        description: 'Version number'
+        type: string
+        required: true
+      force:
+        description: 'Force publish'
+        type: boolean
+        default: false
+        required: true
+
+jobs:
+  tweet:
+    name: Send Release Tweet
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout Repo
+        uses: actions/checkout@master
+      - name: Setup Node.js 14.x
+        uses: actions/setup-node@master
+        with:
+          node-version: 14.x
+      - name: Poll release notes page on devsite
+        run: node scripts/ci/poll_release_notes.js
+        env:
+          VERSION: ${{ github.event.inputs.version }}
+          FORCE_PUBLISH: ${{ github.event.inputs.force }}
+      - name: Post to Twitter
+        uses: firebase/firebase-admin-node/.github/actions/send-tweet@master
+        with:
+          status: >
+            v${{github.event.inputs.version}} of @Firebase JavaScript client for Web / Node.js is available.
+            Release notes: https://firebase.google.com/support/release-notes/js#${{github.event.inputs.version}}
+          consumer-key: ${{ secrets.TWITTER_CONSUMER_KEY }}
+          consumer-secret: ${{ secrets.TWITTER_CONSUMER_SECRET }}
+          access-token: ${{ secrets.TWITTER_ACCESS_TOKEN }}
+          access-token-secret: ${{ secrets.TWITTER_ACCESS_TOKEN_SECRET }}

.changeset/slow-forks-tease.md

@@ -38,7 +38,10 @@ jobs:
         run: xvfb-run yarn test:changed auth
   test-firefox:
     name: Test Auth on Firefox If Changed
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: install Firefox stable

.changeset/strong-squids-dress.md

@@ -34,7 +34,10 @@ jobs:
 
   test-firefox:
     name: Test Firestore on Firefox If Changed
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: install Firefox stable

.github/CODEOWNERS

@@ -34,7 +34,10 @@ jobs:
 
   test-firefox:
     name: Test Packages With Changed Files in Firefox
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: Checkout Repo

.github/workflows/e2e-test.yml

@@ -39,9 +39,6 @@ coverage
 # Grunt intermediate storage (http://gruntjs.com/creating-plugins#storing-task-files)
 .grunt
 
-# Bower dependency directory (https://bower.io/)
-bower_components
-
 # node-waf configuration
 .lock-wscript
 
@@ -92,6 +89,6 @@ packages/**/docs
 tsdoc-metadata.json
 
 # generated html docs
-docs-*/
+docs-rut/
 docs/
 toc/

.github/workflows/merge-release-branch.yml

@@ -73,8 +73,7 @@
         "--exit"
       ],
       "env": {
-        "FIRESTORE_EMULATOR_PORT" : "8080",
-        "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
+        "FIRESTORE_TARGET_BACKEND" : "emulator",
       },
       "sourceMaps": true,
       "protocol": "inspector"
@@ -95,8 +94,7 @@
       ],
       "env": {
         "USE_MOCK_PERSISTENCE": "YES",
-        "FIRESTORE_EMULATOR_PORT" : "8080",
-        "FIRESTORE_EMULATOR_PROJECT_ID" :  "test-emulator"
+        "FIRESTORE_TARGET_BACKEND" : "emulator",
       },
       "sourceMaps": true,
       "protocol": "inspector"

.github/workflows/release-prod.yml

@@ -11,7 +11,6 @@ applications using Firebase services. This SDK is distributed via:
 
 - [CDN](https://firebase.google.com/docs/web/setup/#add-sdks-initialize)
 - [npm package](https://www.npmjs.com/package/firebase)
-- [Bower package](https://github.com/firebase/firebase-bower)
 
 To get started using Firebase, see
 [Add Firebase to your JavaScript Project](https://firebase.google.com/docs/web/setup).
@@ -191,14 +190,16 @@ scope](https://www.npmjs.com/search?q=scope%3Afirebase) on NPM.
 
 ### Testing the SDK Locally
 
-Please be sure to build your repo before proceeding any further.
+Please be sure your product's package has been built before proceeding any further. (If you haven't built this repo before, make sure to run `yarn build` at the root)
 In order to manually test your SDK changes locally, you must use [yarn link](https://classic.yarnpkg.com/en/docs/cli/link):
 
 ```shell
 $ cd packages/firebase
 $ yarn link # initialize the linking to the other folder
-$ cd ../<my-test-app-dir> # cd into your personal project directory
-$ yarn link firebase # tell yarn to use the locally built firebase SDK instead
+$ cd ../packages/<my-product> # Example: $ cd packages/database
+$ yarn link # link your product to make it available elsewhere
+$ cd <my-test-app-dir> # cd into your personal project directory
+$ yarn link firebase @firebase/<my-product> # tell yarn to use the locally built firebase SDK instead
 ```
 
 This will create a symlink and point your `<my-test-app-dir>` to the locally built version of the firebase SDK.