Fix test when running on emulator

Author: tom-andersen

packages/firestore-compat/karma.conf.js

@@ -39,6 +39,11 @@ module.exports = function (config) {
       ...karmaConfig.client,
       targetBackend: argv.targetBackend
     };
+  } else if (argv.local) {
+    karmaConfig.client = {
+      ...karmaConfig.client,
+      targetBackend: 'emulator'
+    };
   }
 
   config.set(karmaConfig);

packages/firestore/CONTRIBUTING.md

@@ -61,7 +61,7 @@ yarn test:browser --integration
 
 # Run browser integration tests against a Firestore server running on
 # localhost:8080.
-yarn test:browser --integration --local
+yarn test:browser:emulator --integration
 
 # Run all node tests once (unit and integration) against the emulator.
 yarn test:node

packages/firestore/karma.conf.js

@@ -39,6 +39,11 @@ module.exports = function (config) {
       ...karmaConfig.client,
       targetBackend: argv.targetBackend
     };
+  } else if (argv.local) {
+    karmaConfig.client = {
+      ...karmaConfig.client,
+      targetBackend: 'emulator'
+    };
   }
 
   config.set(karmaConfig);

packages/firestore/test/integration/browser/webchannel.test.ts

@@ -20,7 +20,7 @@ import { expect } from 'chai';
 import { WebChannelConnection } from '../../../src/platform/browser/webchannel_connection';
 import * as api from '../../../src/protos/firestore_proto_api';
 import { getDefaultDatabaseInfo } from '../util/internal_helpers';
-import { DEFAULT_PROJECT_ID } from '../util/settings';
+import { DEFAULT_PROJECT_ID, USE_EMULATOR } from '../util/settings';
 
 /* eslint-disable no-restricted-globals */
 
@@ -33,7 +33,7 @@ const describeFn =
       xdescribe;
 
 describeFn('WebChannel', () => {
-  it('receives error messages', done => {
+  (USE_EMULATOR ? it.skip : it)('receives error messages', done => {
     const projectId = DEFAULT_PROJECT_ID;
     const info = getDefaultDatabaseInfo();
     const conn = new WebChannelConnection(info);
@@ -67,6 +67,13 @@ describeFn('WebChannel', () => {
     // different database ID.
     stream.onMessage(msg => {
       if (msg.targetChange) {
+        // Assertion will fail when additional targets are added. This works so
+        // long as backend target id counts up from 1. We expect the second
+        // target to be a bad payload. If this does not fail stream, then we
+        // might receive message that it was successfully added. The following
+        // assertion will catch failure to validate data on backend.
+        expect(msg.targetChange?.targetIds).to.not.include(2);
+
         payload.database = 'projects/some-other-project-id/databases/(default)';
         didSendBadPayload = true;
         stream.send(payload);