Skip to content

Commit d2b1436

Browse files
authored
Remove no-longer-necessary asyncIt wrappers. (#302)
1 parent 88c85ef commit d2b1436

24 files changed

+345
-453
lines changed

packages/firestore/test/integration/api/batch_writes.test.ts

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -21,17 +21,16 @@ import * as testHelpers from '../../util/helpers';
2121
import firebase from '../util/firebase_export';
2222
import * as integrationHelpers from '../util/helpers';
2323

24-
const asyncIt = testHelpers.asyncIt;
2524
const apiDescribe = integrationHelpers.apiDescribe;
2625

2726
apiDescribe('Database batch writes', persistence => {
28-
asyncIt('support empty batches', () => {
27+
it('support empty batches', () => {
2928
return integrationHelpers.withTestDb(persistence, db => {
3029
return db.batch().commit();
3130
});
3231
});
3332

34-
asyncIt('can set documents', () => {
33+
it('can set documents', () => {
3534
return integrationHelpers.withTestDoc(persistence, doc => {
3635
return doc.firestore
3736
.batch()
@@ -45,7 +44,7 @@ apiDescribe('Database batch writes', persistence => {
4544
});
4645
});
4746

48-
asyncIt('can set documents with merge', () => {
47+
it('can set documents with merge', () => {
4948
return integrationHelpers.withTestDoc(persistence, doc => {
5049
return doc.firestore
5150
.batch()
@@ -69,7 +68,7 @@ apiDescribe('Database batch writes', persistence => {
6968
});
7069
});
7170

72-
asyncIt('can update documents', () => {
71+
it('can update documents', () => {
7372
return integrationHelpers.withTestDoc(persistence, doc => {
7473
return doc
7574
.set({ foo: 'bar' })
@@ -87,7 +86,7 @@ apiDescribe('Database batch writes', persistence => {
8786
});
8887
});
8988

90-
asyncIt('can delete documents', () => {
89+
it('can delete documents', () => {
9190
return integrationHelpers.withTestDoc(persistence, doc => {
9291
return doc
9392
.set({ foo: 'bar' })
@@ -108,7 +107,7 @@ apiDescribe('Database batch writes', persistence => {
108107
});
109108
});
110109

111-
asyncIt('commit atomically, raising correct events', () => {
110+
it('commit atomically, raising correct events', () => {
112111
return integrationHelpers.withTestCollection(
113112
persistence,
114113
{},
@@ -156,7 +155,7 @@ apiDescribe('Database batch writes', persistence => {
156155
);
157156
});
158157

159-
asyncIt('fail atomically, raising correct events', () => {
158+
it('fail atomically, raising correct events', () => {
160159
return integrationHelpers.withTestCollection(
161160
persistence,
162161
{},
@@ -217,7 +216,7 @@ apiDescribe('Database batch writes', persistence => {
217216
);
218217
});
219218

220-
asyncIt('write the same server timestamp across writes', () => {
219+
it('write the same server timestamp across writes', () => {
221220
return integrationHelpers.withTestCollection(
222221
persistence,
223222
{},
@@ -271,7 +270,7 @@ apiDescribe('Database batch writes', persistence => {
271270
);
272271
});
273272

274-
asyncIt('can write the same document multiple times', () => {
273+
it('can write the same document multiple times', () => {
275274
return integrationHelpers.withTestDoc(persistence, doc => {
276275
const accumulator = new testHelpers.EventsAccumulator<
277276
firestore.DocumentSnapshot
@@ -313,7 +312,7 @@ apiDescribe('Database batch writes', persistence => {
313312
});
314313
});
315314

316-
asyncIt('can update nested fields', () => {
315+
it('can update nested fields', () => {
317316
const initialData = {
318317
desc: 'Description',
319318
owner: { name: 'Jonny' },

packages/firestore/test/integration/api/cursor.test.ts

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616

1717
import { expect } from 'chai';
18-
import { asyncIt, toDataArray } from '../../util/helpers';
18+
import { toDataArray } from '../../util/helpers';
1919
import firebase from '../util/firebase_export';
2020
import {
2121
apiDescribe,
@@ -25,7 +25,7 @@ import {
2525
} from '../util/helpers';
2626

2727
apiDescribe('Cursors', persistence => {
28-
asyncIt('can page through items', () => {
28+
it('can page through items', () => {
2929
const testDocs = {
3030
a: { v: 'a' },
3131
b: { v: 'b' },
@@ -72,7 +72,7 @@ apiDescribe('Cursors', persistence => {
7272
});
7373
});
7474

75-
asyncIt('can be created from documents', () => {
75+
it('can be created from documents', () => {
7676
const testDocs = {
7777
a: { k: 'a', sort: 1 },
7878
b: { k: 'b', sort: 2 },
@@ -109,7 +109,7 @@ apiDescribe('Cursors', persistence => {
109109
});
110110
});
111111

112-
asyncIt('can be created from values', () => {
112+
it('can be created from values', () => {
113113
const testDocs = {
114114
a: { k: 'a', sort: 1 },
115115
b: { k: 'b', sort: 2 },
@@ -140,7 +140,7 @@ apiDescribe('Cursors', persistence => {
140140
});
141141
});
142142

143-
asyncIt('can be created using document id', () => {
143+
it('can be created using document id', () => {
144144
const testDocs: { [key: string]: {} } = {
145145
a: { k: 'a' },
146146
b: { k: 'b' },
@@ -175,7 +175,7 @@ apiDescribe('Cursors', persistence => {
175175
});
176176
});
177177

178-
asyncIt('can be used with reference values', () => {
178+
it('can be used with reference values', () => {
179179
// We require a db to create reference values
180180
return withTestDb(persistence, db => {
181181
const testDocs = {
@@ -202,7 +202,7 @@ apiDescribe('Cursors', persistence => {
202202
});
203203
});
204204

205-
asyncIt('can be used in descending queries', () => {
205+
it('can be used in descending queries', () => {
206206
const testDocs = {
207207
a: { k: 'a', sort: 1 },
208208
b: { k: 'b', sort: 2 },

0 commit comments

Comments
 (0)