Skip to content

Commit cc3146c

Browse files
committed
Re-adding circular dependency check.
1 parent 92c651f commit cc3146c

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

packages/firestore/rollup.shared.js

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,9 @@ exports.resolveNodeExterns = function (id) {
9696

9797
/** Breaks the build if there is a circular dependency. */
9898
exports.onwarn = function (warning, defaultWarn) {
99-
// TODO(pipeline) re-enable and fix circular dependencies after the pipeline exploration phase
100-
// if (warning.code === 'CIRCULAR_DEPENDENCY') {
101-
// console.log(JSON.stringify(warning));
102-
// throw new Error(warning);
103-
// }
99+
if (warning.code === 'CIRCULAR_DEPENDENCY') {
100+
throw new Error(warning);
101+
}
104102
defaultWarn(warning);
105103
};
106104

0 commit comments

Comments
 (0)