Skip to content

Commit c8c6db9

Browse files
committed
Fix type
1 parent dcd5a06 commit c8c6db9

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

packages/logger/src/logger.ts

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -141,15 +141,21 @@ export class Logger {
141141
* The log level of the given Logger instance.
142142
*/
143143
private _logLevel = defaultLogLevel;
144-
get logLevel(): LogLevel | LogLevelString {
144+
145+
get logLevel(): LogLevel {
145146
return this._logLevel;
146147
}
147-
set logLevel(val: LogLevel | LogLevelString) {
148-
const newLevel = typeof val === 'string' ? levelStringToEnum[val] : val;
149-
if (!(newLevel in LogLevel)) {
148+
149+
set logLevel(val: LogLevel) {
150+
if (!(val in LogLevel)) {
150151
throw new TypeError(`Invalid value "${val}" assigned to \`logLevel\``);
151152
}
152-
this._logLevel = newLevel;
153+
this._logLevel = val;
154+
}
155+
156+
// Workaround for setter/getter having to be the same type.
157+
setLogLevel(val: LogLevel | LogLevelString): void {
158+
this._logLevel = typeof val === 'string' ? levelStringToEnum[val] : val;
153159
}
154160

155161
/**
@@ -207,7 +213,7 @@ export class Logger {
207213

208214
export function setLogLevel(level: LogLevelString | LogLevel): void {
209215
instances.forEach(inst => {
210-
inst.logLevel = level;
216+
inst.setLogLevel(level);
211217
});
212218
}
213219

0 commit comments

Comments
 (0)