Fixed duplicate onValue calls

Author: maneesht

packages/database/src/core/PersistentConnection.ts

@@ -206,12 +206,6 @@ export class PersistentConnection extends ServerActions {
       onComplete: (message: { [k: string]: unknown }) => {
         const payload = message['d'] as string;
         if (message['s'] === 'ok') {
-          this.onDataUpdate_(
-            request['p'],
-            payload,
-            /*isMerge*/ false,
-            /*tag*/ null
-          );
           deferred.resolve(payload);
         } else {
           deferred.reject(payload);

packages/database/src/core/Repo.ts

@@ -485,12 +485,10 @@ export function repoGetValue(repo: Repo, query: QueryContext): Promise<Node> {
       } else {
         // Simulate `syncTreeAddEventRegistration` without events/listener setup.
         // TODO: We can probably extract this.
-        const { syncPoint, serverCache, writesCache, serverCacheComplete, viewAlreadyExists, foundAncestorDefaultView } = syncTreeAddToPath(query, repo.serverSyncTree_);
-        if (!viewAlreadyExists && !foundAncestorDefaultView) {
-          const view = syncPointGetView(syncPoint, query, writesCache, serverCache, serverCacheComplete);
-          if (!syncPoint.views.has(query._queryIdentifier)) {
-            syncPoint.views.set(query._queryIdentifier, view);
-          }
+        const { syncPoint, serverCache, writesCache, serverCacheComplete  } = syncTreeAddToPath(query, repo.serverSyncTree_);
+        const view = syncPointGetView(syncPoint, query, writesCache, serverCache, serverCacheComplete);
+        if (!syncPoint.views.has(query._queryIdentifier)) {
+          syncPoint.views.set(query._queryIdentifier, view);
         }
         const tag = syncTreeTagForQuery_(repo.serverSyncTree_, query);
         const events = syncTreeApplyTaggedQueryOverwrite(