Merge branch 'master' into khanrafi/webchannelupgrade

Author: rafikhan

.changeset/cold-impalas-drop.md

@@ -14,6 +14,8 @@
     "@firebase/app-types-exp",
     "@firebase/functions-exp",
     "@firebase/functions-types-exp",
+    "@firebase/installations-exp",
+    "@firebase/installations-types-exp",
     "@firebase/testing",
     "firebase-exp",
     "@firebase/app-compat",

.changeset/config.json

@@ -0,0 +1,5 @@
+---
+"firebase": patch
+---
+
+Escape unicodes when generating CDN scripts, so they work correctly in environments that requires UTF-8, for example, in Chrome extension.

.changeset/honest-doors-poke.md

@@ -2,15 +2,16 @@ name: Health Metrics
 
 on: [push, pull_request]
 
+env:
+  METRICS_SERVICE_URL: ${{ secrets.METRICS_SERVICE_URL }}
+  GITHUB_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
+  GITHUB_PULL_REQUEST_BASE_SHA: ${{ github.event.pull_request.base.sha }}
+
 jobs:
-  binary-size-test:
+  binary-size:
     name: Binary Size
     if: github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)
     runs-on: ubuntu-latest
-    env:
-      METRICS_SERVICE_URL: ${{ secrets.METRICS_SERVICE_URL }}
-      GITHUB_PULL_REQUEST_NUMBER: ${{ github.event.pull_request.number }}
-      GITHUB_PULL_REQUEST_BASE_SHA: ${{ github.event.pull_request.base.sha }}
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
@@ -19,12 +20,24 @@ jobs:
       - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
         with:
           service_account_key: ${{ secrets.GCP_SA_KEY }}
-      - run: cp config/ci.config.json config/project.json
       - run: yarn install
       - run: yarn build
       - name: Run health-metrics/binary-size test
         run: yarn size-report
+  modular-export-size:
+    name: Binary Size For Modular Exports
+    if: github.event_name == 'push' || !(github.event.pull_request.head.repo.fork)
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-node@v1
+        with:
+          node-version: 10.x
+      - uses: GoogleCloudPlatform/github-actions/setup-gcloud@master
+        with:
+          service_account_key: ${{ secrets.GCP_SA_KEY }}
+      - run: yarn install
+      - run: yarn build
       - name: Run health-metrics/modular-exports-binary-size test
         run: yarn modular-export-size-report
-
   # TODO(yifany): Enable startup times testing on CI.

.changeset/small-grapes-teach.md

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   test:
-    name: If Changed
+    name: Test Auth If Changed
     runs-on: ubuntu-latest
 
     steps:

.changeset/tall-mugs-shop.md

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   test:
-    name: If Changed
+    name: Test FCM integration If Changed
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/health-metrics-test.yml

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   test:
-    name: If Changed
+    name: Test Firestore Integration If Changed
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/test-changed-auth.yml

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   test:
-    name: If Changed
+    name: Test Firestore If Changed
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/test-changed-fcm-integration.yml

@@ -4,7 +4,7 @@ on: pull_request
 
 jobs:
   test:
-    name: If Changed
+    name: Test Misc Packages If Changed
     runs-on: ubuntu-latest
 
     steps:

.github/workflows/test-changed-firestore-integration.yml

@@ -1,4 +1,5 @@
 # This file is pre-built and need not be formatted
 packages/auth
 packages/firebase/firebase*
+packages/firestore/scripts
 dist

.github/workflows/test-changed-firestore.yml

@@ -0,0 +1,34 @@
+## API Report File for "@firebase/installations-exp"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+
+import { FirebaseApp } from '@firebase/app-types-exp';
+import { FirebaseInstallations } from '@firebase/installations-types-exp';
+
+// @public
+export function deleteInstallations(installations: FirebaseInstallations): Promise<void>;
+
+// @public
+export function getId(installations: FirebaseInstallations): Promise<string>;
+
+// @public
+export function getInstallations(app: FirebaseApp): FirebaseInstallations;
+
+// @public
+export function getToken(installations: FirebaseInstallations, forceRefresh?: boolean): Promise<string>;
+
+// @public
+export type IdChangeCallbackFn = (installationId: string) => void;
+
+// @public
+export type IdChangeUnsubscribeFn = () => void;
+
+// @public
+export function onIdChange(installations: FirebaseInstallations, callback: IdChangeCallbackFn): IdChangeUnsubscribeFn;
+
+
+// (No @packageDocumentation comment for this package)
+
+```

.github/workflows/test-changed-misc.yml

@@ -0,0 +1,20 @@
+## API Report File for "@firebase/installations-types-exp"
+
+> Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/).
+
+```ts
+
+// @public (undocumented)
+export interface FirebaseInstallations {}
+
+// @internal
+export interface _FirebaseInstallationsInternal {
+  getId(): Promise<string>;
+
+  getToken(forceRefresh?: boolean): Promise<string>;
+}
+
+
+// (No @packageDocumentation comment for this package)
+
+```

.prettierignore

@@ -4,5 +4,6 @@
   "databaseURL": "https://jscore-sandbox-141b5.firebaseio.com",
   "projectId": "jscore-sandbox-141b5",
   "storageBucket": "jscore-sandbox-141b5.appspot.com",
-  "messagingSenderId": "280127633210"
+  "messagingSenderId": "280127633210",
+  "appId": "1:280127633210:web:1eb2f7e8799c4d5a46c203"
 }

common/api-review/installations-exp.api.md

@@ -7,7 +7,7 @@
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
   },
   "devDependencies": {
-    "firebase": "7.19.1",
+    "firebase": "7.21.0",
     "@babel/core": "7.11.4",
     "@babel/preset-env": "7.11.0",
     "@types/chai": "4.2.12",

common/api-review/installations-types-exp.api.md

@@ -14,8 +14,8 @@
     "test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
   },
   "devDependencies": {
-    "@firebase/app": "0.6.10",
-    "@firebase/firestore": "1.16.6",
+    "@firebase/app": "0.6.11",
+    "@firebase/firestore": "1.17.0",
     "@types/mocha": "7.0.2",
     "gulp": "4.0.2",
     "gulp-filter": "6.0.0",

config/ci.config.json

@@ -9,13 +9,13 @@
     "test:manual": "mocha --exit"
   },
   "devDependencies": {
-    "firebase": "7.19.1",
+    "firebase": "7.21.0",
     "chai": "4.2.0",
     "chromedriver": "84.0.1",
     "express": "4.17.1",
     "geckodriver": "1.20.0",
     "mocha": "7.2.0",
-    "node-fetch": "2.6.0",
+    "node-fetch": "2.6.1",
     "selenium-assistant": "6.1.0"
   }
 }

integration/firebase/package.json

@@ -24,7 +24,7 @@
     "dev": "lerna run --parallel --scope @firebase/* --scope firebase --scope rxfire dev",
     "build": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --scope rxfire --ignore @firebase/app-exp build",
     "build:exp": "lerna run --scope @firebase/*-exp --scope @firebase/*-compat --scope firebase-exp build",
-    "build:release": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --scope rxfire --ignore @firebase/*-exp prepare",
+    "build:release": "lerna run --scope @firebase/app-exp build:deps && lerna run --scope @firebase/* --scope firebase --scope rxfire --ignore @firebase/*-exp --ignore @firebase/*-compat prepare",
     "build:exp:release": "yarn --cwd packages/app build:deps && lerna run --scope @firebase/*-exp --scope @firebase/*-compat --scope firebase-exp prepare && yarn --cwd packages-exp/app-exp typings:public",
     "build:changed": "ts-node-script scripts/ci-test/build_changed.ts",
     "link:packages": "lerna exec --scope @firebase/* --scope firebase --scope rxfire -- yarn link",
@@ -101,7 +101,7 @@
     "find-free-port": "2.0.0",
     "firebase-functions": "3.11.0",
     "firebase-tools": "8.9.2",
-    "git-rev-sync": "2.0.0",
+    "git-rev-sync": "3.0.1",
     "glob": "7.1.6",
     "http-server": "0.12.3",
     "husky": "4.2.5",

integration/firestore/package.json

@@ -10,9 +10,7 @@
   "esm2017": "dist/index.esm2017.js",
   "lite": "dist/index.lite.js",
   "lite-esm2017": "dist/index.lite.esm2017.js",
-  "files": [
-    "dist"
-  ],
+  "files": ["dist"],
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts'  --ignore-path '../../.gitignore'",
@@ -31,9 +29,9 @@
   "license": "Apache-2.0",
   "dependencies": {
     "@firebase/app-exp": "0.0.800",
-    "@firebase/util": "0.3.1",
+    "@firebase/util": "0.3.2",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.1.18",
+    "@firebase/component": "0.1.19",
     "tslib": "^1.11.1",
     "dom-storage": "2.1.0",
     "xmlhttprequest": "1.8.0"
@@ -60,4 +58,4 @@
     ],
     "reportDir": "./coverage/node"
   }
-}
+}

integration/messaging/package.json

@@ -31,9 +31,9 @@
   },
   "dependencies": {
     "@firebase/app-types-exp": "0.0.800",
-    "@firebase/util": "0.3.1",
+    "@firebase/util": "0.3.2",
     "@firebase/logger": "0.2.6",
-    "@firebase/component": "0.1.18",
+    "@firebase/component": "0.1.19",
     "tslib": "^1.11.1"
   },
   "license": "Apache-2.0",

package.json

@@ -40,7 +40,7 @@
     "@firebase/app-exp": "0.0.800",
     "@firebase/app-compat": "0.0.800",
     "@firebase/functions-exp": "0.0.800",
-    "@firebase/firestore": "1.16.6"
+    "@firebase/firestore": "1.17.0"
   },
   "devDependencies": {
     "rollup": "2.26.7",

packages-exp/app-compat/package.json

@@ -50,11 +50,11 @@
   },
   "typings": "dist/functions-exp-public.d.ts",
   "dependencies": {
-    "@firebase/component": "0.1.18",
+    "@firebase/component": "0.1.19",
     "@firebase/functions-types-exp": "0.0.800",
     "@firebase/messaging-types": "0.5.0",
-    "@firebase/util": "0.3.1",
-    "isomorphic-fetch": "2.2.1",
+    "@firebase/util": "0.3.2",
+    "node-fetch": "2.6.1",
     "tslib": "^1.11.1"
   },
   "nyc": {

packages-exp/app-exp/package.json

@@ -27,28 +27,31 @@ import { FUNCTIONS_TYPE } from './constants';
 
 export const DEFAULT_REGION = 'us-central1';
 
-const factory: InstanceFactory<'functions'> = (
-  container: ComponentContainer,
-  region?: string
-) => {
-  // Dependencies
-  const app = container.getProvider('app-exp').getImmediate();
-  const authProvider = container.getProvider('auth-internal');
-  const messagingProvider = container.getProvider('messaging');
+export function registerFunctions(fetchImpl: typeof fetch): void {
+  const factory: InstanceFactory<'functions'> = (
+    container: ComponentContainer,
+    region?: string
+  ) => {
+    // Dependencies
+    const app = container.getProvider('app-exp').getImmediate();
+    const authProvider = container.getProvider('auth-internal');
+    const messagingProvider = container.getProvider('messaging');
 
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
-  return new FunctionsService(app, authProvider, messagingProvider, region);
-};
-
-export function registerFunctions(): void {
-  const namespaceExports = {
-    // no-inline
-    Functions: FunctionsService
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    return new FunctionsService(
+      app,
+      authProvider,
+      messagingProvider,
+      region,
+      fetchImpl
+    );
   };
 
   _registerComponent(
-    new Component(FUNCTIONS_TYPE, factory, ComponentType.PUBLIC)
-      .setServiceProps(namespaceExports)
-      .setMultipleInstances(true)
+    new Component(
+      FUNCTIONS_TYPE,
+      factory,
+      ComponentType.PUBLIC
+    ).setMultipleInstances(true)
   );
 }

packages-exp/firebase-exp/package.json

@@ -16,11 +16,12 @@
  */
 import { registerVersion } from '@firebase/app-exp';
 import { registerFunctions } from './config';
-import 'isomorphic-fetch';
+import nodeFetch from 'node-fetch';
 
 import { name, version } from '../package.json';
 
 export * from './api';
 
-registerFunctions();
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+registerFunctions(nodeFetch as any);
 registerVersion(name, version, 'node');

packages-exp/functions-exp/package.json

@@ -21,5 +21,5 @@ import { name, version } from '../package.json';
 
 export * from './api';
 
-registerFunctions();
+registerFunctions(fetch);
 registerVersion(name, version);