Skip to content

Commit c002f36

Browse files
DellaBittaDellaBitta
authored
Merge branch 'master' into ddb-deps
2 parents cf08004 + 1fd9d25 commit c002f36

File tree

63 files changed

+1993
-152
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

63 files changed

+1993
-152
lines changed

‎.changeset/fresh-frogs-heal.md

+6
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
"@firebase/firestore": patch
3+
"@firebase/webchannel-wrapper": patch
4+
---
5+
6+
Fix an issue where Firestore was incorrectly using XHR instead of fetch for streaming response.

‎.github/workflows/test-all.yml

+10-8
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,14 @@ jobs:
1717
# Install Chrome so the correct version of webdriver can be installed by chromedriver when
1818
# setting up the repo. This must be done to build and execute Auth properly.
1919
- name: install Chrome stable
20-
# Install Chrome version 110.0.5481.177-1 as some Auth tests start to fail on version 111.
21-
# Temporary: Auth team will explore what's going wrong with the auth tests.
20+
# Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
21+
# The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
22+
# TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
2223
run: |
2324
sudo apt-get update
2425
sudo apt-get install wget
25-
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb
26-
sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades
26+
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
27+
sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
2728
- uses: actions/checkout@v3
2829
- name: Set up Node (16)
2930
uses: actions/setup-node@v3
@@ -102,13 +103,14 @@ jobs:
102103
steps:
103104
# install Chrome so the correct version of webdriver can be installed by chromedriver when setting up the repo
104105
- name: install Chrome stable
105-
# Install Chrome version 110.0.5481.177-1 as some Auth tests start to fail on version 111.
106-
# Temporary: Auth team will explore what's going wrong with the auth tests.
106+
# Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
107+
# The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
108+
# TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
107109
run: |
108110
sudo apt-get update
109111
sudo apt-get install wget
110-
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb
111-
sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades
112+
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
113+
sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
112114
- name: Download build archive
113115
uses: actions/download-artifact@v3
114116
with:

‎.github/workflows/test-changed-auth.yml

+10-8
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,14 @@ jobs:
1414
steps:
1515
# install Chrome first, so the correct version of webdriver can be installed by chromedriver when setting up the repo
1616
- name: install Chrome stable
17-
# Install Chrome version 110.0.5481.177-1 as test starts to fail on version 111.
18-
# Temporary: Auth team will explore what's going wrong with the auth tests.
17+
# Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
18+
# The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
19+
# TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
1920
run: |
2021
sudo apt-get update
2122
sudo apt-get install wget
22-
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb
23-
sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades
23+
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
24+
sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
2425
- name: Checkout Repo
2526
uses: actions/checkout@master
2627
with:
@@ -48,16 +49,17 @@ jobs:
4849

4950
runs-on: ubuntu-20.04
5051

51-
# Chrome webdriver version is pinned to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790"
52-
# These are installed even in the Firefox test due to `yarn` command which pulls the devDependency listed in package.json.
52+
# Pin Chrome version 114.0.5735.90-1 to avoid install failures like "No such object: chromedriver/LATEST_RELEASE_115.0.5790".
53+
# The failure happens because https://chromedriver.chromium.org/downloads only goes up to version 114.
54+
# TODO(b/297380444) Update script to install the latest Chrome and ChromeDriver.
5355
steps:
5456
- name: install Firefox stable
5557
run: |
5658
sudo apt-get update
5759
sudo apt-get install firefox
5860
sudo apt-get install wget
59-
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_110.0.5481.177-1_amd64.deb
60-
sudo apt-get install -f ./google-chrome-stable_110.0.5481.177-1_amd64.deb --allow-downgrades
61+
sudo wget http://dl.google.com/linux/chrome/deb/pool/main/g/google-chrome-stable/google-chrome-stable_114.0.5735.90-1_amd64.deb
62+
sudo apt-get install -f ./google-chrome-stable_114.0.5735.90-1_amd64.deb --allow-downgrades
6163
6264
- name: Checkout Repo
6365
uses: actions/checkout@master

‎integration/compat-interop/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@
88
"test:debug": "karma start --browsers Chrome --auto-watch"
99
},
1010
"dependencies": {
11-
"@firebase/app": "0.9.17",
12-
"@firebase/app-compat": "0.2.17",
11+
"@firebase/app": "0.9.18",
12+
"@firebase/app-compat": "0.2.18",
1313
"@firebase/analytics": "0.10.0",
1414
"@firebase/analytics-compat": "0.2.6",
1515
"@firebase/auth": "1.3.0",

‎integration/firebase/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"test:ci": "node ../../scripts/run_tests_in_ci.js -s test"
88
},
99
"devDependencies": {
10-
"firebase": "10.3.0",
10+
"firebase": "10.3.1",
1111
"@types/chai": "4.3.5",
1212
"@types/mocha": "9.1.1",
1313
"chai": "4.3.7",

‎integration/firestore/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,8 @@
1414
"test:memory:debug": "yarn build:memory; karma start --auto-watch --browsers Chrome"
1515
},
1616
"dependencies": {
17-
"@firebase/app": "0.9.17",
18-
"@firebase/firestore": "4.1.2"
17+
"@firebase/app": "0.9.18",
18+
"@firebase/firestore": "4.1.3"
1919
},
2020
"devDependencies": {
2121
"@types/mocha": "9.1.1",

‎integration/messaging/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"test:manual": "mocha --exit"
1010
},
1111
"devDependencies": {
12-
"firebase": "10.3.0",
12+
"firebase": "10.3.1",
1313
"chai": "4.3.7",
1414
"chromedriver": "98.0.1",
1515
"express": "4.18.2",

‎packages/analytics-compat/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"@firebase/app-compat": "0.x"
2525
},
2626
"devDependencies": {
27-
"@firebase/app-compat": "0.2.17",
27+
"@firebase/app-compat": "0.2.18",
2828
"rollup": "2.79.1",
2929
"@rollup/plugin-json": "4.1.0",
3030
"rollup-plugin-typescript2": "0.31.2",

‎packages/analytics/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
},
4949
"license": "Apache-2.0",
5050
"devDependencies": {
51-
"@firebase/app": "0.9.17",
51+
"@firebase/app": "0.9.18",
5252
"rollup": "2.79.1",
5353
"@rollup/plugin-commonjs": "21.1.0",
5454
"@rollup/plugin-json": "4.1.0",

‎packages/app-check-compat/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
},
4545
"license": "Apache-2.0",
4646
"devDependencies": {
47-
"@firebase/app-compat": "0.2.17",
47+
"@firebase/app-compat": "0.2.18",
4848
"rollup": "2.79.1",
4949
"@rollup/plugin-commonjs": "21.1.0",
5050
"@rollup/plugin-json": "4.1.0",

‎packages/app-check/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
},
4646
"license": "Apache-2.0",
4747
"devDependencies": {
48-
"@firebase/app": "0.9.17",
48+
"@firebase/app": "0.9.18",
4949
"rollup": "2.79.1",
5050
"@rollup/plugin-commonjs": "21.1.0",
5151
"@rollup/plugin-json": "4.1.0",

‎packages/app-compat/CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# @firebase/app-compat
22

3+
## 0.2.18
4+
5+
### Patch Changes
6+
7+
- Updated dependencies []:
8+
- @firebase/app@0.9.18
9+
310
## 0.2.17
411

512
### Patch Changes

‎packages/app-compat/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/app-compat",
3-
"version": "0.2.17",
3+
"version": "0.2.18",
44
"description": "The primary entrypoint to the Firebase JS SDK",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",
@@ -40,7 +40,7 @@
4040
},
4141
"license": "Apache-2.0",
4242
"dependencies": {
43-
"@firebase/app": "0.9.17",
43+
"@firebase/app": "0.9.18",
4444
"@firebase/util": "1.9.3",
4545
"@firebase/logger": "0.4.0",
4646
"@firebase/component": "0.6.4",

‎packages/app/CHANGELOG.md

+6
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# @firebase/app
22

3+
## 0.9.18
4+
5+
### Patch Changes
6+
7+
- Update SDK_VERSION.
8+
39
## 0.9.17
410

511
### Patch Changes

‎packages/app/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/app",
3-
"version": "0.9.17",
3+
"version": "0.9.18",
44
"description": "The primary entrypoint to the Firebase JS SDK",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.cjs.js",

‎packages/auth-compat/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@
5959
},
6060
"license": "Apache-2.0",
6161
"devDependencies": {
62-
"@firebase/app-compat": "0.2.17",
62+
"@firebase/app-compat": "0.2.18",
6363
"@rollup/plugin-json": "4.1.0",
6464
"rollup": "2.79.1",
6565
"rollup-plugin-replace": "2.2.0",

‎packages/auth/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -120,7 +120,7 @@
120120
},
121121
"license": "Apache-2.0",
122122
"devDependencies": {
123-
"@firebase/app": "0.9.17",
123+
"@firebase/app": "0.9.18",
124124
"@rollup/plugin-json": "4.1.0",
125125
"@rollup/plugin-strip": "2.1.0",
126126
"@types/express": "4.17.17",

‎packages/auth/test/integration/webdriver/redirect.test.ts

+17-4
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,13 @@ import { START_FUNCTION } from './util/auth_driver';
3939
use(chaiAsPromised);
4040

4141
browserDescribe('WebDriver redirect IdP test', driver => {
42-
beforeEach(async () => {
43-
await driver.pause(200); // Race condition on auth init
42+
afterEach(async function () {
43+
this.timeout(25000); // Starting browsers can be slow.
44+
45+
// Redirect tests are flaky on Chrome v111+
46+
// Stop and re-initialize the webdrive instance to prevent flakiness.
47+
await driver.stop();
48+
await driver.start('chrome');
4449
});
4550

4651
it('allows users to sign in', async () => {
@@ -327,7 +332,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
327332
expect(user.email).to.eq(user1.email);
328333
});
329334

330-
it('reauthenticate throws for wrong user', async () => {
335+
it('reauthenticate throws for wrong user', async function () {
336+
// Test is ignored for now as it fails on Chrome version 111+.
337+
// TODO(b/297245662): Investigate and unskip the test.
338+
this.skip();
339+
331340
// Sign in using pre-poulated user
332341
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
333342

@@ -350,7 +359,11 @@ browserDescribe('WebDriver redirect IdP test', driver => {
350359
);
351360
});
352361

353-
it('handles aborted sign ins', async () => {
362+
it('handles aborted sign ins', async function () {
363+
// Test is ignored for now as it fails on Chrome version 111+.
364+
// TODO(b/297245662): Investigate and unskip the test.
365+
this.skip();
366+
354367
await driver.callNoWait(RedirectFunction.IDP_REDIRECT);
355368
const widget = new IdPPage(driver.webDriver);
356369

‎packages/database-compat/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@
5858
"tslib": "^2.1.0"
5959
},
6060
"devDependencies": {
61-
"@firebase/app-compat": "0.2.17",
61+
"@firebase/app-compat": "0.2.18",
6262
"typescript": "4.7.4"
6363
},
6464
"repository": {

‎packages/database/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
"tslib": "^2.1.0"
5858
},
5959
"devDependencies": {
60-
"@firebase/app": "0.9.17",
60+
"@firebase/app": "0.9.18",
6161
"rollup": "2.79.1",
6262
"rollup-plugin-typescript2": "0.31.2",
6363
"typescript": "4.7.4"

‎packages/firebase/CHANGELOG.md

+14
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
# firebase
22

3+
## 10.3.1
4+
5+
### Patch Changes
6+
7+
- [`12221ddb4`](https://github.com/firebase/firebase-js-sdk/commit/12221ddb41766f85d9c2327a8af9ba647cfa9f3e) [#7542](https://github.com/firebase/firebase-js-sdk/pull/7542) - Implemented internal logic to auto-create client-side indexes
8+
9+
- [`25cda8af6`](https://github.com/firebase/firebase-js-sdk/commit/25cda8af6a6fc15e33f0ce5644dd29d996e4716f) [#7587](https://github.com/firebase/firebase-js-sdk/pull/7587) - Implemented internal logic to delete all client-side indexes
10+
11+
- Updated dependencies [[`12221ddb4`](https://github.com/firebase/firebase-js-sdk/commit/12221ddb41766f85d9c2327a8af9ba647cfa9f3e), [`25cda8af6`](https://github.com/firebase/firebase-js-sdk/commit/25cda8af6a6fc15e33f0ce5644dd29d996e4716f)]:
12+
- @firebase/app@0.9.18
13+
- @firebase/firestore@4.1.3
14+
- @firebase/app-compat@0.2.18
15+
- @firebase/firestore-compat@0.3.17
16+
317
## 10.3.0
418

519
### Minor Changes

‎packages/firebase/package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "firebase",
3-
"version": "10.3.0",
3+
"version": "10.3.1",
44
"description": "Firebase JavaScript library for web and Node.js",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"license": "Apache-2.0",
@@ -362,15 +362,15 @@
362362
"test:ci": "echo 'No test suite for firebase wrapper'"
363363
},
364364
"dependencies": {
365-
"@firebase/app": "0.9.17",
366-
"@firebase/app-compat": "0.2.17",
365+
"@firebase/app": "0.9.18",
366+
"@firebase/app-compat": "0.2.18",
367367
"@firebase/app-types": "0.9.0",
368368
"@firebase/auth": "1.3.0",
369369
"@firebase/auth-compat": "0.4.6",
370370
"@firebase/database": "1.0.1",
371371
"@firebase/database-compat": "1.0.1",
372-
"@firebase/firestore": "4.1.2",
373-
"@firebase/firestore-compat": "0.3.16",
372+
"@firebase/firestore": "4.1.3",
373+
"@firebase/firestore-compat": "0.3.17",
374374
"@firebase/functions": "0.10.0",
375375
"@firebase/functions-compat": "0.3.5",
376376
"@firebase/installations": "0.6.4",

‎packages/firestore-compat/CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
11
# @firebase/firestore-compat
22

3+
## 0.3.17
4+
5+
### Patch Changes
6+
7+
- Updated dependencies [[`12221ddb4`](https://github.com/firebase/firebase-js-sdk/commit/12221ddb41766f85d9c2327a8af9ba647cfa9f3e), [`25cda8af6`](https://github.com/firebase/firebase-js-sdk/commit/25cda8af6a6fc15e33f0ce5644dd29d996e4716f)]:
8+
- @firebase/firestore@4.1.3
9+
310
## 0.3.16
411

512
### Patch Changes

‎packages/firestore-compat/package.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@firebase/firestore-compat",
3-
"version": "0.3.16",
3+
"version": "0.3.17",
44
"description": "The Cloud Firestore component of the Firebase JS SDK.",
55
"author": "Firebase <[email protected]> (https://firebase.google.com/)",
66
"main": "dist/index.node.cjs.js",
@@ -48,13 +48,13 @@
4848
},
4949
"dependencies": {
5050
"@firebase/component": "0.6.4",
51-
"@firebase/firestore": "4.1.2",
51+
"@firebase/firestore": "4.1.3",
5252
"@firebase/util": "1.9.3",
5353
"@firebase/firestore-types": "3.0.0",
5454
"tslib": "^2.1.0"
5555
},
5656
"devDependencies": {
57-
"@firebase/app-compat": "0.2.17",
57+
"@firebase/app-compat": "0.2.18",
5858
"@types/eslint": "7.29.0",
5959
"rollup": "2.79.1",
6060
"rollup-plugin-sourcemaps": "0.6.3",

‎packages/firestore/CHANGELOG.md

+8
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,13 @@
11
# @firebase/firestore
22

3+
## 4.1.3
4+
5+
### Patch Changes
6+
7+
- [`12221ddb4`](https://github.com/firebase/firebase-js-sdk/commit/12221ddb41766f85d9c2327a8af9ba647cfa9f3e) [#7542](https://github.com/firebase/firebase-js-sdk/pull/7542) - Implemented internal logic to auto-create client-side indexes
8+
9+
- [`25cda8af6`](https://github.com/firebase/firebase-js-sdk/commit/25cda8af6a6fc15e33f0ce5644dd29d996e4716f) [#7587](https://github.com/firebase/firebase-js-sdk/pull/7587) - Implemented internal logic to delete all client-side indexes
10+
311
## 4.1.2
412

513
### Patch Changes

0 commit comments

Comments
 (0)