Skip to content

Commit be4c443

Browse files
committed
Missed a messaging cookie use, split changelog a bit
1 parent ca62dc6 commit be4c443

File tree

3 files changed

+9
-4
lines changed

3 files changed

+9
-4
lines changed

.changeset/lazy-bulldogs-tickle.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
'@firebase/performance': patch
3+
'@firebase/performance-compat': patch
4+
---
5+
6+
Performance could encounter runtime errors when initialized in certain environments

.changeset/ninety-lions-report.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,8 @@
11
---
22
'@firebase/messaging': patch
3-
'@firebase/performance': patch
43
'@firebase/analytics': patch
54
'@firebase/messaging-compat': patch
6-
'@firebase/performance-compat': patch
75
'@firebase/analytics-compat': patch
86
---
97

10-
checking isSupported led to runtime failures in certain environments
8+
checking isSupported led to runtime errors in certain environments

packages/messaging/src/api/isSupported.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
*/
1717

1818
import {
19+
areCookiesEnabled,
1920
isIndexedDBAvailable,
2021
validateIndexedDBOpenable
2122
} from '@firebase/util';
@@ -34,7 +35,7 @@ export async function isWindowSupported(): Promise<boolean> {
3435
typeof window !== 'undefined' &&
3536
isIndexedDBAvailable() &&
3637
(await validateIndexedDBOpenable()) &&
37-
navigator.cookieEnabled &&
38+
areCookiesEnabled() &&
3839
'serviceWorker' in navigator &&
3940
'PushManager' in window &&
4041
'Notification' in window &&

0 commit comments

Comments
 (0)