Skip to content

Commit bc79c7c

Browse files
committed
Added changset and test comment updates.
1 parent ce6341a commit bc79c7c

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

.changeset/lemon-candles-vanish.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
'@firebase/auth': patch
3+
'firebase': patch
4+
---
5+
6+
Fixed: invoking `connectAuthEmulator` mulitiple times with the same parameters will no longer cause
7+
an error. Fixes [GitHub Issue #6824](https://github.com/firebase/firebase-js-sdk/issues/6824).
8+

packages/auth/src/core/auth/emulator.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ describe('core/auth/emulator', () => {
8484
.throw;
8585
});
8686

87-
it('fails with differeing config if a network request has already been made', async () => {
87+
it('fails with alternate config if a network request has already been made', async () => {
8888
expect(() => connectAuthEmulator(auth, 'http://127.0.0.1:2020')).to.not
8989
.throw;
9090
await user.delete();
@@ -95,11 +95,11 @@ describe('core/auth/emulator', () => {
9595
});
9696

9797
it('subsequent calls update the endpoint appropriately', async () => {
98-
connectAuthEmulator(auth, 'http://127.0.0.2:2020');
98+
connectAuthEmulator(auth, 'http://127.0.0.1:2021');
9999
expect(auth.emulatorConfig).to.eql({
100100
protocol: 'http',
101-
host: '127.0.0.2',
102-
port: 2020,
101+
host: '127.0.0.1',
102+
port: 2021,
103103
options: { disableWarnings: false }
104104
});
105105
connectAuthEmulator(auth, 'http://127.0.0.1:2020');

0 commit comments

Comments
 (0)