Skip to content

Commit b78ed28

Browse files
committed
PR feedback
1 parent 7e7b67b commit b78ed28

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

packages-exp/auth-exp/src/core/auth/auth_impl.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ export class AuthImpl implements Auth, _FirebaseService {
398398
}
399399

400400
async _redirectUserForId(id: string): Promise<User | null> {
401-
// Make sure we've cleared any pending ppersistence actions if we're not in
401+
// Make sure we've cleared any pending persistence actions if we're not in
402402
// the initializer
403403
if (this._isInitialized) {
404404
await this.queue(async () => {});

packages-exp/auth-exp/src/core/user/token_manager.ts

+7-5
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { Auth } from '../../model/auth';
2121
import { IdTokenResponse } from '../../model/id_token';
2222
import { AuthErrorCode } from '../errors';
2323
import { PersistedBlob } from '../persistence';
24-
import { assert, debugFail, fail } from '../util/assert';
24+
import { assert, debugFail } from '../util/assert';
2525

2626
/**
2727
* The number of milliseconds before the official expiration time of a token
@@ -56,11 +56,13 @@ export class StsTokenManager {
5656
return this.accessToken;
5757
}
5858

59-
if (this.accessToken && !this.refreshToken) {
60-
fail(AuthErrorCode.TOKEN_EXPIRED, {
59+
assert(
60+
this.accessToken && !this.refreshToken,
61+
AuthErrorCode.TOKEN_EXPIRED,
62+
{
6163
appName: auth.name
62-
});
63-
}
64+
}
65+
); /* */
6466

6567
await this.refresh(auth, this.refreshToken!);
6668
return this.accessToken;

0 commit comments

Comments
 (0)