Make recaptchaEnterpriseVerifier.verify return a mock when appVerificationDisabledForTesting is true

Author: NhienLam

packages/auth/src/core/credentials/email.test.ts

@@ -137,6 +137,7 @@ describe('core/credentials/email', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
   });
 
   context('email & password', () => {

packages/auth/src/core/strategies/email_and_password.test.ts

@@ -74,6 +74,7 @@ describe('core/strategies/sendPasswordResetEmail', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
     mockFetch.setUp();
   });
 

packages/auth/src/core/strategies/email_link.test.ts

@@ -58,6 +58,7 @@ describe('core/strategies/sendSignInLinkToEmail', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
     mockFetch.setUp();
   });
 

packages/auth/src/platform_browser/providers/phone.test.ts

@@ -42,6 +42,7 @@ describe('platform_browser/providers/phone', () => {
   beforeEach(async () => {
     fetch.setUp();
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
   });
 
   afterEach(() => {

packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.test.ts

@@ -108,6 +108,7 @@ describe('platform_browser/recaptcha/recaptcha_enterprise_verifier', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
     mockFetch.setUp();
     verifier = new RecaptchaEnterpriseVerifier(auth);
     recaptcha = new MockGreCAPTCHATopLevel();

packages/auth/src/platform_browser/recaptcha/recaptcha_enterprise_verifier.ts

@@ -33,6 +33,7 @@ import * as jsHelpers from '../load_js';
 import { AuthErrorCode } from '../../core/errors';
 import { StartPhoneMfaEnrollmentRequest } from '../../api/account_management/mfa';
 import { StartPhoneMfaSignInRequest } from '../../api/authentication/mfa';
+import { MockGreCAPTCHATopLevel } from './recaptcha_mock';
 
 const RECAPTCHA_ENTERPRISE_URL =
   'https://www.google.com/recaptcha/enterprise.js?render=';
@@ -125,6 +126,12 @@ export class RecaptchaEnterpriseVerifier {
       }
     }
 
+    // Returns Promise for a mock token when appVerificationDisabledForTesting is true.
+    if (this.auth.settings.appVerificationDisabledForTesting) {
+      const mockRecaptcha = new MockGreCAPTCHATopLevel();
+      return mockRecaptcha.execute('siteKey', { action: 'verify' });
+    }
+
     return new Promise<string>((resolve, reject) => {
       retrieveSiteKey(this.auth)
         .then(siteKey => {

packages/auth/src/platform_browser/strategies/phone.test.ts

@@ -131,6 +131,7 @@ describe('platform_browser/strategies/phone', () => {
 
   beforeEach(async () => {
     auth = await testAuth();
+    auth.settings.appVerificationDisabledForTesting = false;
     fetch.setUp();
 
     sendCodeEndpoint = mockEndpoint(Endpoint.SEND_VERIFICATION_CODE, {

packages/auth/src/platform_browser/strategies/phone.ts

@@ -227,19 +227,10 @@ export async function _verifyPhoneNumber(
   options: PhoneInfoOptions | string,
   verifier?: ApplicationVerifierInternal
 ): Promise<string> {
-  const enterpriseVerifier = new RecaptchaEnterpriseVerifier(auth);
-  const recaptchaEnterpriseToken = await enterpriseVerifier.verify();
-
-  _assert(
-    typeof recaptchaEnterpriseToken === 'string',
-    auth,
-    AuthErrorCode.ARGUMENT_ERROR
-  );
-  _assert(
-    enterpriseVerifier.type === RECAPTCHA_ENTERPRISE_VERIFIER_TYPE,
-    auth,
-    AuthErrorCode.ARGUMENT_ERROR
-  );
+  if (!auth._getRecaptchaConfig()) {
+    const enterpriseVerifier = new RecaptchaEnterpriseVerifier(auth);
+    await enterpriseVerifier.verify();
+  }
 
   try {
     let phoneInfoOptions: PhoneInfoOptions;