Retry all non-Firestore exceptions

Our users are still seeing IndexedDB errors on iOS 13 (using IONIC/Cordova). One of the possible reasons is that some environments might not throw DOMExceptions, which would lead us to not retry. This PR flips our logic around and only skips retries if the underlying exception is a non-Firestore exception.

Fixes #2232

Author: schmidt-sebastian

packages/firestore/src/local/simple_db.ts

@@ -294,23 +294,23 @@ export class SimpleDb {
         // caller.
         await transaction.completionPromise;
         return transactionFnResult;
-      } catch (e) {
+      } catch (error) {
         // TODO(schmidt-sebastian): We could probably be smarter about this and
         // not retry exceptions that are likely unrecoverable (such as quota
         // exceeded errors).
         const retryable =
           idempotent &&
-          isDomException(e) &&
+          error.name !== 'FirestoreError' &&
           attemptNumber < TRANSACTION_RETRY_COUNT;
         debug(
           LOG_TAG,
           'Transaction failed with error: %s. Retrying: %s.',
-          e.message,
+          error.message,
           retryable
         );
 
         if (!retryable) {
-          return Promise.reject(e);
+          return Promise.reject(error);
         }
       }
     }

packages/firestore/test/unit/local/simple_db.test.ts

@@ -28,6 +28,7 @@ import {
 import { PersistencePromise } from '../../../src/local/persistence_promise';
 
 import { fail } from '../../../src/util/assert';
+import { Code, FirestoreError } from '../../../src/util/error';
 
 use(chaiAsPromised);
 
@@ -551,8 +552,8 @@ describe('SimpleDb', () => {
     await expect(
       db.runTransaction('readwrite-idempotent', ['users'], txn => {
         ++attemptCount;
-        txn.abort();
-        return PersistencePromise.reject(new Error('Aborted'));
+        txn.abort(new FirestoreError(Code.ABORTED, 'Aborted'));
+        return PersistencePromise.reject(new Error());
       })
     ).to.eventually.be.rejected;