Allow aggregations to work with multi-tab. (#7212)

* Allow aggregations to work with multi-tab.

Fixes #7198.

A proper long-term solution for multi-tab should be implemented.

* Create .changeset/three-months-lie.md

* Improve the change log entry.

* Skip the relevant test.

* Skip the relevant test.

Author: ehsannas

.changeset/three-months-lie.md

@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Fix a bug that sometimes prevented aggregations from being run when muli-tab persistence was enabled.

packages/firestore/src/core/firestore_client.ts

@@ -42,7 +42,6 @@ import { newSerializer } from '../platform/serializer';
 import { newTextEncoder } from '../platform/text_serializer';
 import { Datastore, invokeRunAggregationQueryRpc } from '../remote/datastore';
 import {
-  canUseNetwork,
   RemoteStore,
   remoteStoreDisableNetwork,
   remoteStoreEnableNetwork,
@@ -536,20 +535,11 @@ export function firestoreClientRunAggregateQuery(
     // to the implementation in firestoreClientGetDocumentsViaSnapshotListener
     // above
     try {
-      const remoteStore = await getRemoteStore(client);
-      if (!canUseNetwork(remoteStore)) {
-        deferred.reject(
-          new FirestoreError(
-            Code.UNAVAILABLE,
-            'Failed to get aggregate result because the client is offline.'
-          )
-        );
-      } else {
-        const datastore = await getDatastore(client);
-        deferred.resolve(
-          invokeRunAggregationQueryRpc(datastore, query, aggregates)
-        );
-      }
+      // TODO(b/277628384): check `canUseNetwork()` and handle multi-tab.
+      const datastore = await getDatastore(client);
+      deferred.resolve(
+        invokeRunAggregationQueryRpc(datastore, query, aggregates)
+      );
     } catch (e) {
       deferred.reject(e as Error);
     }

packages/firestore/test/integration/api/aggregation.test.ts

@@ -115,7 +115,9 @@ apiDescribe('Count queries', (persistence: boolean) => {
     });
   });
 
-  it('getCountFromServer fails if user is offline', () => {
+  // TODO(b/277628384): Re-enable this test once b/277628384 is fixed.
+  // eslint-disable-next-line no-restricted-properties
+  it.skip('getCountFromServer fails if user is offline', () => {
     return withEmptyTestCollection(persistence, async (coll, firestore) => {
       await disableNetwork(firestore);
       await expect(getCountFromServer(coll)).to.be.eventually.rejectedWith(
@@ -293,7 +295,9 @@ apiDescribe('Aggregation queries', (persistence: boolean) => {
     });
   });
 
-  it('getAggregateFromServer fails if user is offline', () => {
+  // TODO(b/277628384): Re-enable this test once b/277628384 is fixed.
+  // eslint-disable-next-line no-restricted-properties
+  it.skip('getAggregateFromServer fails if user is offline', () => {
     return withEmptyTestCollection(persistence, async (coll, firestore) => {
       await disableNetwork(firestore);
       await expect(getCountFromServer(coll)).to.be.eventually.rejectedWith(