Skip to content

Commit b41f528

Browse files
committed
rename the flag
1 parent 49f3a95 commit b41f528

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

packages/firestore/src/core/sync_engine_impl.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1081,13 +1081,13 @@ async function applyDocChanges(
10811081

10821082
const targetChange =
10831083
remoteEvent && remoteEvent.targetChanges.get(queryView.targetId);
1084-
const isPendingForRequeryResult =
1084+
const waitForRequeryResult =
10851085
remoteEvent && remoteEvent.targetMismatches.get(queryView.targetId) != null;
10861086
const viewChange = queryView.view.applyChanges(
10871087
viewDocChanges,
10881088
/* updateLimboDocuments= */ syncEngineImpl.isPrimaryClient,
10891089
targetChange,
1090-
isPendingForRequeryResult
1090+
waitForRequeryResult
10911091
);
10921092
updateTrackedLimbos(
10931093
syncEngineImpl,

packages/firestore/src/core/view.ts

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ export class View {
273273
* @param docChanges - The set of changes to make to the view's docs.
274274
* @param updateLimboDocuments - Whether to update limbo documents based on
275275
* this change.
276-
* @param isPendingForRequeryResult - Whether the target is pending to run a full
276+
* @param waitForRequeryResult - Whether the target is pending to run a full
277277
* re-query due to existence filter mismatch.
278278
* @param targetChange - A target change to apply for computing limbo docs and
279279
* sync state.
@@ -284,7 +284,7 @@ export class View {
284284
docChanges: ViewDocumentChanges,
285285
updateLimboDocuments: boolean,
286286
targetChange?: TargetChange,
287-
isPendingForRequeryResult?: boolean
287+
waitForRequeryResult?: boolean
288288
): ViewChange {
289289
debugAssert(
290290
!docChanges.needsRefill,
@@ -304,17 +304,15 @@ export class View {
304304

305305
this.applyTargetChange(targetChange);
306306
const limboChanges =
307-
!isPendingForRequeryResult && updateLimboDocuments
307+
!waitForRequeryResult && updateLimboDocuments
308308
? this.updateLimboDocuments()
309309
: [];
310310

311311
// We are at synced state if there is no limbo docs are waiting to be resolved, view is current
312312
// with the backend, and the query is not pending for full re-query result due to existence
313313
// filter mismatch.
314314
const synced =
315-
this.limboDocuments.size === 0 &&
316-
this.current &&
317-
!isPendingForRequeryResult;
315+
this.limboDocuments.size === 0 && this.current && !waitForRequeryResult;
318316

319317
const newSyncState = synced ? SyncState.Synced : SyncState.Local;
320318
const syncStateChanged = newSyncState !== this.syncState;

0 commit comments

Comments
 (0)