Merge ef4e236 into 46596de

Author: maneesht

.changeset/chilled-forks-accept.md

@@ -0,0 +1,5 @@
+---
+"@firebase/storage": patch
+---
+
+Fixed issue where clients using Node.js v18 would use the native `Blob` object which is incompatible with `node-fetch`

packages/storage/src/implementation/type.ts

@@ -15,6 +15,7 @@
  * limitations under the License.
  */
 
+import { isNodeSdk } from '@firebase/util';
 import { invalidArgument } from './error';
 
 export function isJustDef<T>(p: T | null | undefined): p is T | null {
@@ -39,7 +40,9 @@ export function isNativeBlob(p: unknown): p is Blob {
 }
 
 export function isNativeBlobDefined(): boolean {
-  return typeof Blob !== 'undefined';
+  // Note: The `isNodeSdk()` check can be removed when `ts-node` adds native Blob support
+  // PR: https://github.com/node-fetch/node-fetch/pull/1664
+  return typeof Blob !== 'undefined' && !isNodeSdk();
 }
 
 export function validateNumber(

packages/storage/test/unit/task.test.ts

@@ -505,6 +505,7 @@ describe('Firebase Storage > Upload Task', () => {
 
     // Function that notifies when we are in the middle of an exponential backoff
     const readyToCancel = new Promise<null>(resolve => {
+      // @ts-ignore The types for `stub.callsFake` is incompatible with types of `clock.setTimeout`
       stub.callsFake((fn, timeout) => {
         // @ts-ignore The types for `stub.callsFake` is incompatible with types of `clock.setTimeout`
         const res = fakeSetTimeout(fn, timeout);