Skip to content

Commit b2346f3

Browse files
author
Brian Chen
committed
small cleanup
1 parent df56eb2 commit b2346f3

File tree

2 files changed

+13
-1
lines changed

2 files changed

+13
-1
lines changed

packages/firestore/src/api/database.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1458,7 +1458,7 @@ export function newQueryFilter(
14581458
dataReader,
14591459
methodName,
14601460
value,
1461-
op === Operator.IN || op === Operator.NOT_IN
1461+
/* allowArrays= */ op === Operator.IN || op === Operator.NOT_IN
14621462
);
14631463
}
14641464
const filter = FieldFilter.create(fieldPath, op, fieldValue);

packages/firestore/test/unit/core/query.test.ts

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -239,6 +239,18 @@ describe('Query', () => {
239239
});
240240
expect(queryMatches(query1, document)).to.be.true;
241241

242+
// Null match.
243+
document = doc('collection/1', 0, {
244+
zip: null
245+
});
246+
expect(queryMatches(query1, document)).to.be.true;
247+
248+
// NaN match.
249+
document = doc('collection/1', 0, {
250+
zip: Number.NaN
251+
});
252+
expect(queryMatches(query1, document)).to.be.true;
253+
242254
// Direct match.
243255
document = doc('collection/1', 0, { zip: 12345 });
244256
expect(queryMatches(query1, document)).to.be.false;

0 commit comments

Comments
 (0)