Skip to content

Commit b068b72

Browse files
on CI
1 parent 351be56 commit b068b72

File tree

3 files changed

+7
-8
lines changed

3 files changed

+7
-8
lines changed

packages/firestore/src/platform/browser/webchannel_connection.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ export class WebChannelConnection extends RestConnection {
335335
// it's most probably a connection issue
336336
logWarn(LOG_TAG, 'RPC "' + rpcName + '" failed');
337337
reject(
338-
new FirestoreError(Code.UNAVAILABLE, 'Connection failed.')
338+
new FirestoreError(Code.UNAVAILABLE, `Connection failed. ${url} ${requestString}`)
339339
);
340340
}
341341
break;

packages/firestore/src/remote/rest_connection.ts

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -28,11 +28,10 @@ import { Indexable } from '../util/misc';
2828
const LOG_TAG = 'RestConnection';
2929

3030
/** Maps RPC names to the corresponding REST endpoint name. */
31-
const RPC_NAME_URL_MAPPING: StringMap = {
32-
BatchGetDocuments: 'batchGet',
33-
Commit: 'commit',
34-
RunQuery: 'runQuery'
35-
};
31+
const RPC_NAME_URL_MAPPING: StringMap = {};
32+
RPC_NAME_URL_MAPPING['BatchGetDocuments'] = 'batchGet';
33+
RPC_NAME_URL_MAPPING['Commit'] = 'commit';
34+
RPC_NAME_URL_MAPPING['RunQuery'] = 'runQuery';
3635

3736
const RPC_URL_VERSION = 'v1';
3837
const X_GOOG_API_CLIENT_VALUE = 'gl-js/ fire/' + SDK_VERSION;
@@ -88,7 +87,7 @@ export abstract class RestConnection implements Connection {
8887
return response;
8988
},
9089
(err: FirestoreError) => {
91-
logWarn(LOG_TAG, 'Error reported', err.message, jsonObj);
90+
logWarn(LOG_TAG, 'Error reported', err.message, url, jsonObj);
9291
throw err;
9392
}
9493
);

packages/firestore/test/integration/api/transactions.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ apiDescribe('Database transactions', (persistence: boolean) => {
410410
});
411411
});
412412

413-
it('can update nested fields transactionally', () => {
413+
it.only('can update nested fields transactionally', () => {
414414
const initialData = {
415415
desc: 'Description',
416416
owner: { name: 'Jonny' },

0 commit comments

Comments
 (0)