remove 'exclusive'

Author: milaGGL

packages/firestore/src/remote/existence_filter.ts

@@ -19,6 +19,5 @@ import { BloomFilter as ProtoBloomFilter } from '../protos/firestore_proto_api';
 
 export class ExistenceFilter {
   // TODO(b/33078163): just use simplest form of existence filter for now
-  constructor(public count: number, public unchangedNames?: ProtoBloomFilter) {
-  }
+  constructor(public count: number, public unchangedNames?: ProtoBloomFilter) {}
 }

packages/firestore/src/remote/serializer.ts

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 
-import { resumeTokenForSnapshot } from '../../test/util/helpers';
 import { Bound } from '../core/bound';
 import { DatabaseId } from '../core/database_info';
 import {

packages/firestore/test/unit/specs/existence_filter_spec.test.ts

@@ -23,7 +23,7 @@ import { describeSpec, specTest } from './describe_spec';
 import { spec } from './spec_builder';
 import { RpcError } from './spec_rpc_error';
 
-describeSpec('Existence Filters:', ['exclusive'], () => {
+describeSpec('Existence Filters:', [], () => {
   specTest('Existence filter match', [], () => {
     const query1 = query('collection');
     const doc1 = doc('collection/1', 1000, { v: 1 });
@@ -35,18 +35,20 @@ describeSpec('Existence Filters:', ['exclusive'], () => {
       .watchSnapshots(2000);
   });
 
-  // TODO:(mila) update the tests when bloom filter is 
-  specTest('Existence filter with bloom filter match', ['exclusive'], () => {
+  // This test is only to make sure watchFilters can accept bloom filter.
+  // TODO:(mila) update the tests when bloom filter logic is implemented.
+  specTest('Existence filter with bloom filter match', [], () => {
     const query1 = query('collection');
     const doc1 = doc('collection/1', 1000, { v: 1 });
     return spec()
       .userListens(query1)
       .watchAcksFull(query1, 1000, doc1)
       .expectEvents(query1, { added: [doc1] })
-      .watchFilters([query1], [doc1.key],{bits:{bitmap:"a",padding:1}, hashCount:1})
-      .watchSnapshots(2000)
-      .watchFilters([query1])
-      .watchSnapshots(3000);
+      .watchFilters([query1], [doc1.key], {
+        bits: { bitmap: 'a', padding: 1 },
+        hashCount: 1
+      })
+      .watchSnapshots(2000);
   });
 
   specTest('Existence filter match after pending update', [], () => {
@@ -126,8 +128,9 @@ describeSpec('Existence Filters:', ['exclusive'], () => {
     );
   });
 
-  // todo
-  specTest('Existence filter mismatch triggers bloom filter', ['exclusive'], () => {
+  // This test is only to make sure watchFilters can accept bloom filter.
+  // TODO:(mila) update the tests when bloom filter logic is implemented.
+  specTest('Existence filter mismatch triggers bloom filter', [], () => {
     const query1 = query('collection');
     const doc1 = doc('collection/1', 1000, { v: 1 });
     const doc2 = doc('collection/2', 1000, { v: 2 });
@@ -136,7 +139,10 @@ describeSpec('Existence Filters:', ['exclusive'], () => {
         .userListens(query1)
         .watchAcksFull(query1, 1000, doc1, doc2)
         .expectEvents(query1, { added: [doc1, doc2] })
-        .watchFilters([query1], [doc1.key],{bits:{bitmap:"a",padding:1},hashCount:3}) // in the next sync doc2 was deleted
+        .watchFilters([query1], [doc1.key], {
+          bits: { bitmap: 'a', padding: 1 },
+          hashCount: 3
+        }) // in the next sync doc2 was deleted
         .watchSnapshots(2000)
         // query is now marked as "inconsistent" because of filter mismatch
         .expectEvents(query1, { fromCache: true })

packages/firestore/test/unit/specs/spec_builder.ts

@@ -33,7 +33,7 @@ import { DocumentKey } from '../../../src/model/document_key';
 import { FieldIndex } from '../../../src/model/field_index';
 import { JsonObject } from '../../../src/model/object_value';
 import { ResourcePath } from '../../../src/model/path';
-import { BloomFilter as ProtoBloomFilter} from '../../../src/protos/firestore_proto_api';
+import { BloomFilter as ProtoBloomFilter } from '../../../src/protos/firestore_proto_api';
 import {
   isPermanentWriteError,
   mapCodeFromRpcCode,

packages/firestore/test/util/spec_test_helpers.ts

@@ -46,7 +46,7 @@ export function encodeWatchChange(
       filter: {
         targetId: watchChange.targetId,
         count: watchChange.existenceFilter.count,
-        unchangedNames:watchChange.existenceFilter.unchangedNames
+        unchangedNames: watchChange.existenceFilter.unchangedNames
       }
     };
   }