Skip to content

Commit a3fba4e

Browse files
committed
replace asserts with expects
1 parent bff4275 commit a3fba4e

File tree

1 file changed

+26
-27
lines changed

1 file changed

+26
-27
lines changed

packages/util/test/deepCopy.test.ts

+26-27
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* See the License for the specific language governing permissions and
1515
* limitations under the License.
1616
*/
17-
import { assert, expect } from 'chai';
17+
import { expect } from 'chai';
1818
import { deepCopy, deepExtend } from '../src/deepCopy';
1919

2020
describe('deepCopy()', () => {
@@ -26,66 +26,65 @@ describe('deepCopy()', () => {
2626

2727
it('Date', () => {
2828
const d = new Date();
29-
assert.deepEqual(deepCopy(d), d);
29+
expect(deepCopy(d)).to.deep.equal(d);
3030
});
3131

3232
it('Object', () => {
33-
assert.deepEqual(deepCopy({}), {});
34-
assert.deepEqual(deepCopy({ a: 123 }), { a: 123 });
35-
assert.deepEqual(deepCopy({ a: { b: 123 } }), { a: { b: 123 } });
33+
expect(deepCopy({})).to.deep.equal({});
34+
expect(deepCopy({ a: 123 })).to.deep.equal({ a: 123 });
35+
expect(deepCopy({ a: { b: 123 } })).to.deep.equal({ a: { b: 123 } });
3636
});
3737

3838
it('Array', () => {
39-
assert.deepEqual(deepCopy([]), []);
40-
assert.deepEqual(deepCopy([123, 456]), [123, 456]);
41-
assert.deepEqual(deepCopy([123, [456]]), [123, [456]]);
39+
expect(deepCopy([])).to.deep.equal([]);
40+
expect(deepCopy([123, 456])).to.deep.equal([123, 456]);
41+
expect(deepCopy([123, [456]])).to.deep.equal([123, [456]]);
4242
});
4343
});
4444

4545
describe('deepExtend', () => {
4646
it('Scalars', () => {
47-
assert.strictEqual(deepExtend(1, true), true);
48-
assert.strictEqual(deepExtend(undefined, 123), 123);
49-
assert.strictEqual(deepExtend('was', 'abc'), 'abc');
47+
expect(deepExtend(1, true)).to.equal(true);
48+
expect(deepExtend(undefined, 123)).to.equal(123);
49+
expect(deepExtend('was', 'abc')).to.equal('abc');
5050
});
5151

5252
it('Date', () => {
5353
const d = new Date();
54-
assert.deepEqual(deepExtend(new Date(), d), d);
54+
expect(deepExtend(new Date(), d)).to.deep.equal(d);
5555
});
5656

5757
it('Object', () => {
58-
assert.deepEqual(deepExtend({ old: 123 }, {}), { old: 123 });
59-
assert.deepEqual(deepExtend({ old: 123 }, { s: 'hello' }), {
58+
expect(deepExtend({ old: 123 }, {})).to.deep.equal({ old: 123 });
59+
expect(deepExtend({ old: 123 }, { s: 'hello' })).to.deep.equal({
6060
old: 123,
6161
s: 'hello'
6262
});
63-
assert.deepEqual(
64-
deepExtend({ old: 123, a: { c: 'in-old' } }, { a: { b: 123 } }),
65-
{ old: 123, a: { b: 123, c: 'in-old' } }
66-
);
63+
expect(
64+
deepExtend({ old: 123, a: { c: 'in-old' } }, { a: { b: 123 } })
65+
).to.deep.equal({ old: 123, a: { b: 123, c: 'in-old' } });
6766
});
6867

6968
it('Array', () => {
70-
assert.deepEqual(deepExtend([1], []), []);
71-
assert.deepEqual(deepExtend([1], [123, 456]), [123, 456]);
72-
assert.deepEqual(deepExtend([1], [123, [456]]), [123, [456]]);
69+
expect(deepExtend([1], [])).to.deep.equal([]);
70+
expect(deepExtend([1], [123, 456])).to.deep.equal([123, 456]);
71+
expect(deepExtend([1], [123, [456]])).to.deep.equal([123, [456]]);
7372
});
7473

7574
it('Array is copied - not referenced', () => {
7675
const o1 = { a: [1] };
7776
const o2 = { a: [2] };
7877

79-
assert.deepEqual(deepExtend(o1, o2), { a: [2] });
78+
expect(deepExtend(o1, o2)).to.deep.equal({ a: [2] });
8079
o2.a.push(3);
81-
assert.deepEqual(o1, { a: [2] });
80+
expect(o1).to.deep.equal({ a: [2] });
8281
});
8382

8483
it('Array with undefined elements', () => {
8584
const a: any = [];
8685
a[3] = '3';
8786
const b = deepExtend(undefined, a);
88-
assert.deepEqual(b, [, , , '3']);
87+
expect(b).to.deep.equal([, , , '3']);
8988
});
9089

9190
it('Function', () => {
@@ -100,11 +99,11 @@ describe('deepExtend', () => {
10099
},
101100
{ a: source }
102101
);
103-
assert.deepEqual({ a: source }, target);
104-
assert.strictEqual(source, target.a);
102+
expect({ a: source }).to.deep.equal(target);
103+
expect(source).to.equal(target.a);
105104
});
106105

107-
it.only('does not extend property __proto__', () => {
106+
it('does not extend property __proto__', () => {
108107
const src = JSON.parse('{ "__proto__": { "polluted": "polluted" } }');
109108
const a = {};
110109
deepExtend(a, src);

0 commit comments

Comments
 (0)