Merge branch 'master' into mila/BloomFilter

Author: milaGGL

.changeset/six-brooms-listen.md

@@ -0,0 +1,5 @@
+---
+'@firebase/auth': patch
+---
+
+move selenium-webdriver to devDependencies

.github/workflows/test-changed-auth.yml

@@ -38,7 +38,10 @@ jobs:
         run: xvfb-run yarn test:changed auth
   test-firefox:
     name: Test Auth on Firefox If Changed
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: install Firefox stable

.github/workflows/test-changed-firestore.yml

@@ -34,7 +34,10 @@ jobs:
 
   test-firefox:
     name: Test Firestore on Firefox If Changed
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: install Firefox stable

.github/workflows/test-changed.yml

@@ -34,7 +34,10 @@ jobs:
 
   test-firefox:
     name: Test Packages With Changed Files in Firefox
-    runs-on: ubuntu-latest
+    # Whatever version of Firefox comes with 22.04 is causing Firefox
+    # startup to hang when launched by karma. Need to look further into
+    # why.
+    runs-on: ubuntu-20.04
 
     steps:
       - name: Checkout Repo

README.md

@@ -190,14 +190,16 @@ scope](https://www.npmjs.com/search?q=scope%3Afirebase) on NPM.
 
 ### Testing the SDK Locally
 
-Please be sure to build your repo before proceeding any further.
+Please be sure your product's package has been built before proceeding any further. (If you haven't built this repo before, make sure to run `yarn build` at the root)
 In order to manually test your SDK changes locally, you must use [yarn link](https://classic.yarnpkg.com/en/docs/cli/link):
 
 ```shell
 $ cd packages/firebase
 $ yarn link # initialize the linking to the other folder
-$ cd ../<my-test-app-dir> # cd into your personal project directory
-$ yarn link firebase # tell yarn to use the locally built firebase SDK instead
+$ cd ../packages/<my-product> # Example: $ cd packages/database
+$ yarn link # link your product to make it available elsewhere
+$ cd <my-test-app-dir> # cd into your personal project directory
+$ yarn link firebase @firebase/<my-product> # tell yarn to use the locally built firebase SDK instead
 ```
 
 This will create a symlink and point your `<my-test-app-dir>` to the locally built version of the firebase SDK.

packages/auth-compat/package.json

@@ -51,7 +51,6 @@
     "@firebase/component": "0.5.21",
     "@firebase/util": "1.7.3",
     "node-fetch": "2.6.7",
-    "selenium-webdriver": "4.5.0",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",
@@ -61,6 +60,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
+    "selenium-webdriver": "4.5.0",
     "typescript": "4.2.2"
   },
   "repository": {

packages/auth/package.json

@@ -106,7 +106,6 @@
     "@firebase/logger": "0.3.4",
     "@firebase/util": "1.7.3",
     "node-fetch": "2.6.7",
-    "selenium-webdriver": "4.5.0",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",
@@ -118,6 +117,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
+    "selenium-webdriver": "4.5.0",
     "typescript": "4.2.2",
     "@types/express": "4.17.14"
   },