WIP

Author: schmidt-sebastian

packages/storage/.run/All Tests.run.xml

@@ -11,7 +11,7 @@
       <env name="TS_NODE_CACHE" value="NO" />
     </envs>
     <ui>bdd</ui>
-    <extra-mocha-options>--require ts-node/register/type-check --require index.ts</extra-mocha-options>
+    <extra-mocha-options>--require ts-node/register/type-check --require index.node.ts</extra-mocha-options>
     <test-kind>PATTERN</test-kind>
     <test-pattern>test/{,!(browser)/**/}*.test.ts</test-pattern>
     <method v="2" />

packages/storage/package.json

@@ -22,7 +22,7 @@
     "test:browser:unit": "karma start --single-run --unit",
     "test:browser:integration": "karma start --single-run --integration",
     "test:browser": "karma start --single-run",
-    "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.ts --config ../../config/mocharc.node.js",
+    "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha 'test/{,!(browser)/**/}*.test.ts' --file src/index.node.ts --config ../../config/mocharc.node.js",
     "test:debug": "karma start --browser=Chrome",
     "prettier": "prettier --write 'src/**/*.ts' 'test/**/*.ts'",
     "api-report": "api-extractor run --local --verbose && ts-node-script ../../repo-scripts/prune-dts/prune-dts.ts --input dist/storage-public.d.ts --output dist/storage-public.d.ts",

packages/storage/src/reference.ts

@@ -157,8 +157,12 @@ export function getBytesInternal(
     ref.storage
       .makeRequestWithTokens(requestInfo, newBytesConnection)
       .then(request => request.getPromise())
-      // GCS may not honor the Range header for small files
-      .then(bytes =>maxDownloadSizeBytes!==undefined? bytes.slice(0, maxDownloadSizeBytes):bytes)
+      .then(bytes =>
+        maxDownloadSizeBytes !== undefined
+          // GCS may not honor the Range header for small files
+          ? bytes.slice(0, maxDownloadSizeBytes)
+          : bytes
+      )
   );
 }
 

packages/storage/test/integration/integration.test.ts

@@ -90,7 +90,7 @@ describe('FirebaseStorage Exp', () => {
     );
   });
 
-  it('can get first n bytes', async () => {
+  it.only('can get first n bytes', async () => {
     const reference = ref(storage, 'public/exp-bytes');
     await uploadBytes(reference, new Uint8Array([0, 1, 3]));
     const bytes = await getBytes(reference, 2);