Merge branch 'main' of https://github.com/firebase/firebase-js-sdk into tomandersen/restartFirestoreClient

Author: tom-andersen

.changeset/khaki-numbers-nail.md

@@ -0,0 +1,6 @@
+---
+'@firebase/auth': patch
+'@firebase/util': minor
+---
+
+Suppress the use of the `fetch` parameter `referrerPolicy` within Auth for `fetch` requests originating from Cloudflare Workers. Clouldflare Worker environments do not support this parameter and throw when it's used.

.changeset/warm-oranges-itch.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': patch
+---
+
+Fix an issue with metadata `fromCache` defaulting to `true` when listening to cache in multi-tabs.

.github/ISSUE_TEMPLATE/bug_report_v2.yaml

@@ -1,4 +1,4 @@
-# Copyright 2023 Google LLC
+# Copyright 2024 Google LLC
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
@@ -21,7 +21,7 @@ body:
     id: before-you-start
     attributes:
       value: |
-        *[READ THIS]:* to evaluate if you are in the right place?
+        *[READ THIS]:* Are you in the right place?
         - For issues or feature requests related to __the code in this repository__, file a GitHub issue.
         - If this is a __feature request__, make sure the issue title starts with "FR:".
         - For general technical questions, post a question on [StackOverflow](http://stackoverflow.com/) with the firebase tag.
@@ -31,31 +31,31 @@ body:
     id: operating-system
     attributes:
       label: Operating System
-      description: Describe your operating system
-      placeholder: ex. iOS 16.4
+      description: Describe the operating system(s) where you are experiencing the issue.
+      placeholder: ex. iOS 16.4, macOS Ventura 13.4, Windows 11
     validations:
       required: true
   - type: input
-    id: browser-version
+    id: environment
     attributes:
-      label: Browser Version
-      description: Describe your browser version
-      placeholder: ex. Safari/604.1
+      label: Environment (if applicable)
+      description: Describe the environment where you are experiencing the issue. This could include the browser and its version, Node.js version, or any other relevant environment details.
+      placeholder: ex. Chrome 115, Node.js v18.16.0, React Native 
     validations:
       required: true
   - type: input
     id: firebase-sdk-version
     attributes:
       label: Firebase SDK Version
-      description: Describe your Firebase SDK Version
+      description: The Firebase JS SDK version you're using.
       placeholder: ex. 9.16.0
     validations:
       required: true
   - type: dropdown
     id: firebase-sdk-products
     attributes:
-      label: 'Firebase SDK Product:'
-      description: Which Firebase Products are used in your app?
+      label: Firebase SDK Product(s)
+      description: Select the Firebase product(s) relevant to your issue. You can select multiple options in the dropdown.
       multiple: true
       options:
         - Analytics
@@ -77,16 +77,21 @@ body:
   - type: textarea
     id: project-tooling
     attributes:
-      label: Describe your project's tooling
+      label: Project Tooling
       description: Describe the tooling your app is built with
       placeholder: React app with Webpack and Jest
     validations:
       required: true
   - type: textarea
     id: describe-your-problem
     attributes:
-      label: Describe the problem
-      description: Describe what you were trying to do and what occurred
+      label: Detailed Problem Description
+      description: |
+        Please provide a clear and concise description of the problem. Include:
+        - What you were trying to achieve.
+        - What actually happened.
+        - Any error messages or unexpected behavior you observed.
+        - Relevant log snippets or console output (if available).
       placeholder: |
         What were you trying to accomplish? What happened? This should include a background description, log/console output, etc.
     validations:
@@ -95,6 +100,8 @@ body:
     id: reproduce-code
     attributes:
       label: Steps and code to reproduce issue
-      description: Please provide a description of how to replicate your issue. Copy and paste any relevant code here to reproduce the problem or links to code to reproduce it.
+      description: |
+        If possible, provide a minimal, self-contained code snippet or steps that consistently reproduce the issue. 
+        This will significantly aid in debugging.
     validations:
       required: true

.github/workflows/check-docs.yml

@@ -36,7 +36,12 @@ jobs:
     - name: Run doc generation
       run: yarn docgen:all
     - name: Check for changes in docs-devsite dir (fail if so)
-      run: git diff --exit-code docs-devsite
+      run: |
+        if [[ -n "$(git status docs-devsite --porcelain)" ]]; then
+          echo "Unstaged changes detected:"
+          git status -s
+          exit 1
+        fi
     - name: Reference documentation needs to be updated. See message below.
       if: ${{ failure() }}
       run: echo "Changes in this PR affect the reference docs. Run \`yarn docgen:all\` locally to regenerate docs and add them to this PR."

.github/workflows/test-all.yml

@@ -92,7 +92,7 @@ jobs:
     - name: Run unit tests
       # Ignore auth and firestore since they're handled in their own separate jobs.
       run: |
-        xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' --concurrency 4 test:ci
+        xvfb-run yarn lerna run --ignore '{firebase-messaging-integration-test,@firebase/auth*,@firebase/firestore*,firebase-firestore-integration-test}' test:ci
         node scripts/print_test_logs.js
       env:
         FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
@@ -142,7 +142,7 @@ jobs:
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
       run: |
-        xvfb-run yarn lerna run --concurrency 4 test:ci --scope '@firebase/auth*'
+        xvfb-run yarn lerna run test:ci --scope '@firebase/auth*'
         node scripts/print_test_logs.js
       env:
         FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}
@@ -182,7 +182,7 @@ jobs:
       run: echo "FIREBASE_CI_TEST_START_TIME=$(date +%s)" >> $GITHUB_ENV
     - name: Run unit tests
       run: |
-        xvfb-run yarn lerna run --concurrency 4 test:ci --scope '@firebase/firestore*'
+        xvfb-run yarn lerna run test:ci --scope '@firebase/firestore*'
         node scripts/print_test_logs.js
       env:
         FIREBASE_TOKEN: ${{ secrets.FIREBASE_CLI_TOKEN }}

common/api-review/util.api.md

@@ -264,6 +264,11 @@ export function isBrowser(): boolean;
 // @public (undocumented)
 export function isBrowserExtension(): boolean;
 
+// Warning: (ae-missing-release-tag) "isCloudflareWorker" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
+//
+// @public
+export function isCloudflareWorker(): boolean;
+
 // Warning: (ae-missing-release-tag) "isElectron" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)
 //
 // @public

config/karma.base.js

@@ -66,7 +66,8 @@ const config = {
 
   webpackMiddleware: { quiet: true, stats: { colors: true } },
 
-  singleRun: false,
+  // Exit with an exit code of 0 if any of the tests fail.
+  singleRun: true,
 
   client: {
     mocha: {