Don't raise hasPendingWrites for documents outside of limit (#1178)

Author: schmidt-sebastian

packages/firestore/src/core/view.ts

@@ -207,6 +207,7 @@ export class View {
       while (newDocumentSet.size > this.query.limit!) {
         const oldDoc = newDocumentSet.last();
         newDocumentSet = newDocumentSet.delete(oldDoc!.key);
+        newMutatedKeys = newMutatedKeys.delete(oldDoc!.key);
         changeSet.track({ type: ChangeType.Removed, doc: oldDoc! });
       }
     }

packages/firestore/test/unit/specs/limit_spec.test.ts

@@ -41,6 +41,31 @@ describeSpec('Limits:', [], () => {
       });
   });
 
+  specTest(
+    "Documents outside of limit don't raise hasPendingWrites",
+    [],
+    () => {
+      const query1 = Query.atPath(path('collection')).withLimit(2);
+      const doc1 = doc('collection/a', 1000, { key: 'a' });
+      const doc2 = doc('collection/b', 1000, { key: 'b' });
+
+      return spec()
+        .withGCEnabled(false)
+        .userListens(query1)
+        .watchAcksFull(query1, 1000, doc1, doc2)
+        .expectEvents(query1, {
+          added: [doc1, doc2]
+        })
+        .userUnlistens(query1)
+        .userSets('collection/c', { key: 'c' })
+        .userListens(query1, 'resume-token-1000')
+        .expectEvents(query1, {
+          added: [doc1, doc2],
+          fromCache: true
+        });
+    }
+  );
+
   specTest('Deleted Document in limbo in full limit query', [], () => {
     const query = Query.atPath(path('collection')).withLimit(2);
     const doc1 = doc('collection/a', 1000, { key: 'a' });