Invoke RemoteStore's credential change listener even when user didn't change

Author: schmidt-sebastian

common/api-review/firestore-exp.api.md

@@ -11,7 +11,6 @@ import { _FirebaseService } from '@firebase/app-types-exp';
 import { LogLevelString as LogLevel } from '@firebase/logger';
 import { Provider } from '@firebase/component';
 import { SetOptions as SetOptions_2 } from '@firebase/firestore-types';
-import { SnapshotMetadata as SnapshotMetadata_2 } from '@firebase/firestore-types';
 
 // @public
 export function addDoc<T>(reference: CollectionReference<T>, data: T): Promise<DocumentReference<T>>;
@@ -440,11 +439,11 @@ export interface SnapshotListenOptions {
 }
 
 // @public
-export class SnapshotMetadata implements SnapshotMetadata_2 {
+export class SnapshotMetadata {
     constructor(hasPendingWrites: boolean, fromCache: boolean);
     readonly fromCache: boolean;
     readonly hasPendingWrites: boolean;
-    isEqual(other: SnapshotMetadata_2): boolean;
+    isEqual(other: SnapshotMetadata): boolean;
 }
 
 // @public

common/api-review/firestore-lite.api.md

@@ -168,8 +168,10 @@ export abstract class FieldValue {
     abstract _toFieldTransform(context: ParseContext): FieldTransform | null;
 }
 
+// Warning: (ae-forgotten-export) The symbol "FirestoreService" needs to be exported by the entry point index.d.ts
+//
 // @public
-export class FirebaseFirestore implements _FirebaseService {
+export class FirebaseFirestore implements FirestoreService {
     constructor(databaseIdOrApp: DatabaseId | FirebaseApp, authProvider: Provider<FirebaseAuthInternalName>);
     get app(): FirebaseApp;
     // Warning: (ae-forgotten-export) The symbol "CredentialsProvider" needs to be exported by the entry point index.d.ts

packages/firestore/src/core/firestore_client.ts

@@ -118,10 +118,8 @@ export class FirestoreClient {
   ) {
     this.credentials.setChangeListener(user => {
       logDebug(LOG_TAG, 'Received user=', user.uid);
-      if (!this.user.isEqual(user)) {
-        this.user = user;
-        this.credentialListener(user);
-      }
+      this.user = user;
+      this.credentialListener(user);
       this.receivedInitialUser.resolve();
     });
   }
@@ -199,11 +197,15 @@ export async function setOfflineComponentProvider(
   const configuration = await client.getConfiguration();
   await offlineComponentProvider.initialize(configuration);
 
-  client.setCredentialChangeListener(user =>
-    client.asyncQueue.enqueueRetryable(async () => {
-      await handleUserChange(offlineComponentProvider.localStore, user);
-    })
-  );
+  let currentUser = configuration.initialUser;
+  client.setCredentialChangeListener(user => {
+    if (!currentUser.isEqual(user)) {
+      currentUser = user;
+      client.asyncQueue.enqueueRetryable(async () => {
+        await handleUserChange(offlineComponentProvider.localStore, user);
+      });
+    }
+  });
 
   // When a user calls clearPersistence() in one client, all other clients
   // need to be terminated to allow the delete to succeed.