Skip to content

Commit 9b609cd

Browse files
Revert
1 parent 3d1906a commit 9b609cd

File tree

3 files changed

+16
-33
lines changed

3 files changed

+16
-33
lines changed

common/api-review/auth-exp.api.md

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,8 @@ export class EmailAuthProvider implements AuthProvider {
216216
readonly providerId = ProviderId.PASSWORD;
217217
}
218218

219-
// Warning: (ae-forgotten-export) The symbol "BaseOAuthProvider" needs to be exported by the entry point index.d.ts
220-
//
221219
// @public
222-
export class FacebookAuthProvider extends BaseOAuthProvider {
220+
export class FacebookAuthProvider extends OAuthProvider {
223221
constructor();
224222
static credential(accessToken: string): OAuthCredential;
225223
static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -257,7 +255,7 @@ export function getMultiFactorResolver(auth: Auth, error: MultiFactorError_2): M
257255
export function getRedirectResult(auth: Auth, resolver?: PopupRedirectResolver): Promise<UserCredential | null>;
258256

259257
// @public
260-
export class GithubAuthProvider extends BaseOAuthProvider {
258+
export class GithubAuthProvider extends OAuthProvider {
261259
constructor();
262260
static credential(accessToken: string): OAuthCredential;
263261
static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -267,7 +265,7 @@ export class GithubAuthProvider extends BaseOAuthProvider {
267265
}
268266

269267
// @public
270-
export class GoogleAuthProvider extends BaseOAuthProvider {
268+
export class GoogleAuthProvider extends OAuthProvider {
271269
constructor();
272270
static credential(idToken?: string | null, accessToken?: string | null): OAuthCredential;
273271
static credentialFromError(error: FirebaseError): OAuthCredential | null;
@@ -382,13 +380,23 @@ export interface OAuthCredentialOptions {
382380
}
383381

384382
// @public
385-
export class OAuthProvider extends BaseOAuthProvider {
383+
export class OAuthProvider implements AuthProvider {
384+
constructor(providerId: string);
385+
addScope(scope: string): AuthProvider;
386386
credential(params: OAuthCredentialOptions): OAuthCredential;
387387
static credentialFromError(error: FirebaseError): OAuthCredential | null;
388388
// (undocumented)
389389
static credentialFromJSON(json: object | string): OAuthCredential;
390390
static credentialFromResult(userCredential: UserCredential): OAuthCredential | null;
391-
}
391+
// @internal (undocumented)
392+
defaultLanguageCode: string | null;
393+
getCustomParameters(): CustomParameters;
394+
getScopes(): string[];
395+
// (undocumented)
396+
readonly providerId: string;
397+
setCustomParameters(customOAuthParameters: CustomParameters): AuthProvider;
398+
setDefaultLanguage(languageCode: string | null): void;
399+
}
392400

393401
// @public
394402
export function onAuthStateChanged(auth: Auth, nextOrObserver: NextOrObserver<User>, error?: ErrorFn, completed?: CompleteFn): Unsubscribe;
@@ -558,19 +566,6 @@ export class RecaptchaVerifier implements ApplicationVerifierInternal {
558566
// @public
559567
export function reload(user: User): Promise<void>;
560568

561-
// Warning: (ae-forgotten-export) The symbol "FederatedAuthProvider" needs to be exported by the entry point index.d.ts
562-
//
563-
// @public
564-
export class SAMLAuthProvider extends FederatedAuthProvider {
565-
constructor(providerId: string);
566-
// (undocumented)
567-
static credentialFromError(error: FirebaseError): AuthCredential | null;
568-
// (undocumented)
569-
static credentialFromJSON(json: string | object): AuthCredential;
570-
// (undocumented)
571-
static credentialFromResult(userCredential: UserCredential): AuthCredential | null;
572-
}
573-
574569
// @public
575570
export function sendEmailVerification(user: User, actionCodeSettings?: ActionCodeSettings | null): Promise<void>;
576571

@@ -631,7 +626,7 @@ export function signInWithRedirect(auth: Auth, provider: AuthProvider, resolver?
631626
export function signOut(auth: Auth): Promise<void>;
632627

633628
// @public
634-
export class TwitterAuthProvider extends BaseOAuthProvider {
629+
export class TwitterAuthProvider extends OAuthProvider {
635630
constructor();
636631
static credential(token: string, secret: string): OAuthCredential;
637632
static credentialFromError(error: FirebaseError): OAuthCredential | null;

common/api-review/firestore-exp.api.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ export class CollectionReference<T = DocumentData> extends Query<T> {
5353
get path(): string;
5454
// (undocumented)
5555
readonly type = "collection";
56-
withConverter(converter: null): CollectionReference<DocumentData>;
57-
// (undocumented)
5856
withConverter<U>(converter: FirestoreDataConverter<U>): CollectionReference<U>;
5957
}
6058

@@ -103,8 +101,6 @@ export class DocumentReference<T = DocumentData> {
103101
get parent(): CollectionReference<T>;
104102
get path(): string;
105103
readonly type = "document";
106-
withConverter(converter: null): DocumentReference<DocumentData>;
107-
// (undocumented)
108104
withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
109105
}
110106

@@ -322,8 +318,6 @@ export class Query<T = DocumentData> {
322318
protected constructor();
323319
readonly firestore: FirebaseFirestore;
324320
readonly type: 'query' | 'collection';
325-
withConverter(converter: null): Query<DocumentData>;
326-
// (undocumented)
327321
withConverter<U>(converter: FirestoreDataConverter<U>): Query<U>;
328322
}
329323

common/api-review/firestore-lite.api.md

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,6 @@ export class CollectionReference<T = DocumentData> extends Query<T> {
4747
get path(): string;
4848
// (undocumented)
4949
readonly type = "collection";
50-
withConverter(converter: null): CollectionReference<DocumentData>;
51-
// (undocumented)
5250
withConverter<U>(converter: FirestoreDataConverter<U>): CollectionReference<U>;
5351
}
5452

@@ -83,8 +81,6 @@ export class DocumentReference<T = DocumentData> {
8381
get parent(): CollectionReference<T>;
8482
get path(): string;
8583
readonly type = "document";
86-
withConverter(converter: null): DocumentReference<DocumentData>;
87-
// (undocumented)
8884
withConverter<U>(converter: FirestoreDataConverter<U>): DocumentReference<U>;
8985
}
9086

@@ -199,8 +195,6 @@ export class Query<T = DocumentData> {
199195
protected constructor();
200196
readonly firestore: FirebaseFirestore;
201197
readonly type: 'query' | 'collection';
202-
withConverter(converter: null): Query<DocumentData>;
203-
// (undocumented)
204198
withConverter<U>(converter: FirestoreDataConverter<U>): Query<U>;
205199
}
206200

0 commit comments

Comments
 (0)