Skip to content

Commit 8ec3ba9

Browse files
schmidt-sebastianschmidt-sebastian
committed
Feedback
1 parent 709eaab commit 8ec3ba9

File tree

2 files changed

+42
-14
lines changed

2 files changed

+42
-14
lines changed

‎packages/firestore/lite/test/dependencies.json

Lines changed: 39 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,10 @@
7171
"assertUint8ArrayAvailable",
7272
"binaryStringFromUint8Array",
7373
"blobEquals",
74+
"boundEquals",
7475
"canonicalId",
7576
"canonifyArray",
77+
"canonifyBound",
7678
"canonifyByteString",
7779
"canonifyGeoPoint",
7880
"canonifyMap",
@@ -151,6 +153,8 @@
151153
"primitiveComparator",
152154
"refValue",
153155
"registerFirestore",
156+
"sortsBeforeDocument",
157+
"stringifyTarget",
154158
"targetEquals",
155159
"timestampEquals",
156160
"toBytes",
@@ -238,7 +242,7 @@
238242
],
239243
"variables": []
240244
},
241-
"sizeInBytes": 97396
245+
"sizeInBytes": 97991
242246
},
243247
"DocumentReference": {
244248
"dependencies": {
@@ -774,7 +778,7 @@
774778
],
775779
"variables": []
776780
},
777-
"sizeInBytes": 88429
781+
"sizeInBytes": 87202
778782
},
779783
"QueryDocumentSnapshot": {
780784
"dependencies": {
@@ -1274,8 +1278,10 @@
12741278
"assertUint8ArrayAvailable",
12751279
"binaryStringFromUint8Array",
12761280
"blobEquals",
1281+
"boundEquals",
12771282
"canonicalId",
12781283
"canonifyArray",
1284+
"canonifyBound",
12791285
"canonifyByteString",
12801286
"canonifyGeoPoint",
12811287
"canonifyMap",
@@ -1363,6 +1369,8 @@
13631369
"refValue",
13641370
"registerFirestore",
13651371
"serverTimestamp",
1372+
"sortsBeforeDocument",
1373+
"stringifyTarget",
13661374
"targetEquals",
13671375
"timestampEquals",
13681376
"toBytes",
@@ -1466,7 +1474,7 @@
14661474
],
14671475
"variables": []
14681476
},
1469-
"sizeInBytes": 107674
1477+
"sizeInBytes": 108269
14701478
},
14711479
"arrayRemove": {
14721480
"dependencies": {
@@ -1697,8 +1705,10 @@
16971705
"assertUint8ArrayAvailable",
16981706
"binaryStringFromUint8Array",
16991707
"blobEquals",
1708+
"boundEquals",
17001709
"canonicalId",
17011710
"canonifyArray",
1711+
"canonifyBound",
17021712
"canonifyByteString",
17031713
"canonifyGeoPoint",
17041714
"canonifyMap",
@@ -1778,6 +1788,8 @@
17781788
"primitiveComparator",
17791789
"refValue",
17801790
"registerFirestore",
1791+
"sortsBeforeDocument",
1792+
"stringifyTarget",
17811793
"targetEquals",
17821794
"timestampEquals",
17831795
"toBytes",
@@ -1866,7 +1878,7 @@
18661878
],
18671879
"variables": []
18681880
},
1869-
"sizeInBytes": 98024
1881+
"sizeInBytes": 98619
18701882
},
18711883
"collectionGroup": {
18721884
"dependencies": {
@@ -1877,8 +1889,10 @@
18771889
"assertUint8ArrayAvailable",
18781890
"binaryStringFromUint8Array",
18791891
"blobEquals",
1892+
"boundEquals",
18801893
"canonicalId",
18811894
"canonifyArray",
1895+
"canonifyBound",
18821896
"canonifyByteString",
18831897
"canonifyGeoPoint",
18841898
"canonifyMap",
@@ -1958,6 +1972,8 @@
19581972
"primitiveComparator",
19591973
"refValue",
19601974
"registerFirestore",
1975+
"sortsBeforeDocument",
1976+
"stringifyTarget",
19611977
"targetEquals",
19621978
"timestampEquals",
19631979
"toBytes",
@@ -2044,7 +2060,7 @@
20442060
],
20452061
"variables": []
20462062
},
2047-
"sizeInBytes": 97455
2063+
"sizeInBytes": 98050
20482064
},
20492065
"deleteDoc": {
20502066
"dependencies": {
@@ -2235,8 +2251,10 @@
22352251
"assertUint8ArrayAvailable",
22362252
"binaryStringFromUint8Array",
22372253
"blobEquals",
2254+
"boundEquals",
22382255
"canonicalId",
22392256
"canonifyArray",
2257+
"canonifyBound",
22402258
"canonifyByteString",
22412259
"canonifyGeoPoint",
22422260
"canonifyMap",
@@ -2317,6 +2335,8 @@
23172335
"randomBytes",
23182336
"refValue",
23192337
"registerFirestore",
2338+
"sortsBeforeDocument",
2339+
"stringifyTarget",
23202340
"targetEquals",
23212341
"timestampEquals",
23222342
"toBytes",
@@ -2406,7 +2426,7 @@
24062426
],
24072427
"variables": []
24082428
},
2409-
"sizeInBytes": 98845
2429+
"sizeInBytes": 99440
24102430
},
24112431
"documentId": {
24122432
"dependencies": {
@@ -2828,7 +2848,7 @@
28282848
],
28292849
"variables": []
28302850
},
2831-
"sizeInBytes": 94239
2851+
"sizeInBytes": 93121
28322852
},
28332853
"increment": {
28342854
"dependencies": {
@@ -3005,8 +3025,10 @@
30053025
"assertUint8ArrayAvailable",
30063026
"binaryStringFromUint8Array",
30073027
"blobEquals",
3028+
"boundEquals",
30083029
"canonicalId",
30093030
"canonifyArray",
3031+
"canonifyBound",
30103032
"canonifyByteString",
30113033
"canonifyGeoPoint",
30123034
"canonifyMap",
@@ -3086,6 +3108,8 @@
30863108
"primitiveComparator",
30873109
"refValue",
30883110
"registerFirestore",
3111+
"sortsBeforeDocument",
3112+
"stringifyTarget",
30893113
"targetEquals",
30903114
"timestampEquals",
30913115
"toBytes",
@@ -3173,7 +3197,7 @@
31733197
],
31743198
"variables": []
31753199
},
3176-
"sizeInBytes": 97739
3200+
"sizeInBytes": 98334
31773201
},
31783202
"queryEqual": {
31793203
"dependencies": {
@@ -3342,7 +3366,7 @@
33423366
],
33433367
"variables": []
33443368
},
3345-
"sizeInBytes": 88633
3369+
"sizeInBytes": 87406
33463370
},
33473371
"refEqual": {
33483372
"dependencies": {
@@ -3353,8 +3377,10 @@
33533377
"assertUint8ArrayAvailable",
33543378
"binaryStringFromUint8Array",
33553379
"blobEquals",
3380+
"boundEquals",
33563381
"canonicalId",
33573382
"canonifyArray",
3383+
"canonifyBound",
33583384
"canonifyByteString",
33593385
"canonifyGeoPoint",
33603386
"canonifyMap",
@@ -3434,6 +3460,8 @@
34343460
"refEqual",
34353461
"refValue",
34363462
"registerFirestore",
3463+
"sortsBeforeDocument",
3464+
"stringifyTarget",
34373465
"targetEquals",
34383466
"timestampEquals",
34393467
"toBytes",
@@ -3521,7 +3549,7 @@
35213549
],
35223550
"variables": []
35233551
},
3524-
"sizeInBytes": 97681
3552+
"sizeInBytes": 98276
35253553
},
35263554
"runTransaction": {
35273555
"dependencies": {
@@ -4142,7 +4170,7 @@
41424170
],
41434171
"variables": []
41444172
},
4145-
"sizeInBytes": 89366
4173+
"sizeInBytes": 88139
41464174
},
41474175
"terminate": {
41484176
"dependencies": {

‎packages/firestore/src/core/query.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -799,9 +799,9 @@ export function boundEquals(left: Bound | null, right: Bound | null): boolean {
799799
return false;
800800
}
801801
for (let i = 0; i < left.position.length; i++) {
802-
const thisPosition = left.position[i];
803-
const otherPosition = right.position[i];
804-
if (!valueEquals(thisPosition, otherPosition)) {
802+
const leftPosition = left.position[i];
803+
const rightPosition = right.position[i];
804+
if (!valueEquals(leftPosition, rightPosition)) {
805805
return false;
806806
}
807807
}

0 commit comments

Comments
 (0)