Skip to content

Commit 8db30a1

Browse files
committed
resolve comments
1 parent 716f149 commit 8db30a1

File tree

4 files changed

+4
-1
lines changed

4 files changed

+4
-1
lines changed

.changeset/little-rats-relax.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@
33
'firebase': patch
44
---
55

6-
Fix "missing index" error.
6+
Fix "missing index" error message to include the create composite index link.

packages/firestore/test/integration/api/aggregation.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,6 +123,7 @@ apiDescribe('Count quries', (persistence: boolean) => {
123123
// Only verify the error message for missing indexes when running against
124124
// production, since the Firestore Emulator does not require index creation
125125
// and will, therefore, never fail in this situation.
126+
// eslint-disable-next-line no-restricted-properties
126127
(USE_EMULATOR ? it.skip : it)(
127128
'getCountFromServer error message is good if missing index',
128129
() => {

packages/firestore/test/integration/api/query.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,7 @@ apiDescribe('Queries', (persistence: boolean) => {
651651
});
652652
});
653653

654+
// eslint-disable-next-line no-restricted-properties
654655
(USE_EMULATOR ? it.skip : it)(
655656
'can catch error message for missing index with error handler',
656657
() => {

packages/firestore/test/lite/integration.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2385,6 +2385,7 @@ describe('Count quries', () => {
23852385
// Only verify the error message for missing indexes when running against
23862386
// production, since the Firestore Emulator does not require index creation
23872387
// and will, therefore, never fail in this situation.
2388+
// eslint-disable-next-line no-restricted-properties
23882389
(USE_EMULATOR ? it.skip : it)(
23892390
'getCount error message is good if missing index',
23902391
() => {

0 commit comments

Comments
 (0)