Merge remote-tracking branch 'origin/master' at 1b33fda

Author: dconeybe

.changeset/dirty-balloons-unite.md

@@ -0,0 +1,5 @@
+---
+"@firebase/auth": patch
+---
+
+Fix typings where the constructor of `OAuthProvider` was missing.

.changeset/eleven-swans-drive.md

@@ -0,0 +1,8 @@
+---
+'@firebase/analytics-compat': patch
+'@firebase/app-check-compat': patch
+'@firebase/app-compat': patch
+'@firebase/functions-compat': patch
+---
+
+Fix cjs builds by removing the named export from app-compat

.changeset/late-bobcats-swim.md

@@ -0,0 +1,5 @@
+---
+'@firebase/firestore': patch
+---
+
+Make firestore/lite available in nodejs

.changeset/slimy-jobs-wave.md

@@ -0,0 +1,5 @@
+---
+"@firebase/app-compat": patch
+---
+
+Remove private types in app-compat

.changeset/twelve-items-wonder.md

@@ -0,0 +1,6 @@
+---
+'@firebase/firestore': patch
+'@firebase/storage': patch
+---
+
+Addressed incorrect use of the `node-fetch` polyfill

.github/CODEOWNERS

@@ -57,10 +57,10 @@ packages/messaging-interop-types @zwu52 @chliangGoogle @ciarand @firebase/jssdk-
 integration/messaging @zwu52 @chliangGoogle @ciarand @firebase/jssdk-global-approvers
 
 # Auth Code
-packages/auth  @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
+packages/auth  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
 packages/auth-compat @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-types  @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
-packages/auth-interop-types  @bojeil-google @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
+packages/auth-types @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
+packages/auth-interop-types @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers
 
 # Testing Code
 packages/rules-unit-testing  @avolkovi @sam-gc @yuchenshi @firebase/jssdk-global-approvers

README.md

@@ -2,7 +2,6 @@
 
 <!-- BADGES -->
 ![Build Status](https://img.shields.io/github/workflow/status/firebase/firebase-js-sdk/Run%20All%20Tests.svg)
-[![Build Status](https://saucelabs.com/buildstatus/firebase-oss)](https://saucelabs.com/u/firebase-oss)
 [![Version](https://img.shields.io/npm/v/firebase.svg?label=version)](https://www.npmjs.com/package/firebase)
 [![Coverage Status](https://coveralls.io/repos/github/firebase/firebase-js-sdk/badge.svg?branch=master)](https://coveralls.io/github/firebase/firebase-js-sdk?branch=master)
 <!-- END BADGES -->
@@ -19,6 +18,8 @@ To get started using Firebase, see
 
 [![Release Notes](https://img.shields.io/npm/v/firebase.svg?style=flat-square&label=Release%20Notes%20for&labelColor=039be5&color=666)](https://firebase.google.com/support/release-notes/js)
 
+## Upgrade to Version 9
+Version 9 has a redesigned API that supports tree-shaking. Read the [Upgrade Guide](https://firebase.google.com/docs/web/modular-upgrade) to learn more.
 ## Supported Environments
 Please see [Environment Support](https://firebase.google.com/support/guides/environments_js-sdk).
 
@@ -88,9 +89,26 @@ $ yarn build
 A production project is required to test the Firebase JS SDK. You can create a
 new project by visiting the [Firebase Console](https://console.firebase.google.com/).
 
+#### Web App Setup
+
+Visit the "Project Overview" and select "Add app" under your project name. Register the app with a
+nickname and click through the remaining steps. Without performing this step, you will encounter
+the error in the test setup:
+
+```
+FirebaseError: There are no WEB apps associated with this Firebase project
+```
+
 #### Firestore Database Setup
 
-Visit the "Database" section of the console and create a Cloud Firestore
+Visit the "Firestore Database" section of the console and create a Cloud Firestore
+database. When prompted to select the set of initial security rules, select
+any option (e.g. "Start in Production Mode") since these permission settings
+will be overwritten below.
+
+#### Realtime Database Setup
+
+Visit the "Realtime Database" section of the console and create a realtime
 database. When prompted to select the set of initial security rules, select
 any option (e.g. "Start in Production Mode") since these permission settings
 will be overwritten below.

integration/messaging/package.json

@@ -13,7 +13,7 @@
     "chai": "4.3.4",
     "chromedriver": "91.0.0",
     "express": "4.17.1",
-    "geckodriver": "1.22.3",
+    "geckodriver": "2.0.3",
     "mocha": "7.2.0",
     "node-fetch": "2.6.1",
     "selenium-assistant": "6.1.0"

packages/analytics-compat/src/service.test.ts

@@ -16,7 +16,7 @@
  */
 import { expect, use } from 'chai';
 import { AnalyticsService } from './service';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import * as analyticsExp from '@firebase/analytics';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';

packages/app-check-compat/src/service.test.ts

@@ -16,7 +16,7 @@
  */
 import { expect, use } from 'chai';
 import { AppCheckService } from './service';
-import { firebase, FirebaseApp } from '@firebase/app-compat';
+import firebase, { FirebaseApp } from '@firebase/app-compat';
 import * as appCheckExp from '@firebase/app-check';
 import { stub, match, SinonStub } from 'sinon';
 import * as sinonChai from 'sinon-chai';
@@ -65,7 +65,7 @@ describe('Firebase App Check > Service', () => {
 
   it(
     'activate("string") calls modular initializeAppCheck() with a ' +
-      'ReCaptchaV3Provider',
+    'ReCaptchaV3Provider',
     () => {
       const initializeAppCheckStub = stub(appCheckExp, 'initializeAppCheck');
       service = new AppCheckService(app);
@@ -80,7 +80,7 @@ describe('Firebase App Check > Service', () => {
 
   it(
     'activate(CustomProvider) calls modular initializeAppCheck() with' +
-      ' a CustomProvider',
+    ' a CustomProvider',
     () => {
       const initializeAppCheckStub = stub(appCheckExp, 'initializeAppCheck');
       service = new AppCheckService(app);
@@ -167,7 +167,7 @@ describe('Firebase App Check > Service', () => {
 
   it('onTokenChanged() throws if activate() has not been called', async () => {
     service = createTestService(app);
-    expect(() => service.onTokenChanged(() => {})).to.throw(
+    expect(() => service.onTokenChanged(() => { })).to.throw(
       AppCheckError.USE_BEFORE_ACTIVATION
     );
   });

packages/app-compat/api-extractor.json

@@ -0,0 +1,16 @@
+{
+    "extends": "../../config/api-extractor.json",
+    // Point it to your entry point d.ts file. 
+    "mainEntryPointFilePath": "<projectFolder>/dist/src/index.d.ts",
+    "dtsRollup": {
+        "enabled": true,
+        "untrimmedFilePath": "<projectFolder>/dist/<unscopedPackageName>.d.ts",
+        "publicTrimmedFilePath": "<projectFolder>/dist/<unscopedPackageName>-public.d.ts"
+    },
+    "apiReport": {
+        /**
+         * only dts rollup is needed for app-compat
+         */
+        "enabled": false
+    }
+}

packages/app-compat/package.json

@@ -14,15 +14,17 @@
   "scripts": {
     "lint": "eslint -c .eslintrc.js '**/*.ts' --ignore-path '../../.gitignore'",
     "lint:fix": "eslint --fix -c .eslintrc.js '**/*.ts'  --ignore-path '../../.gitignore'",
-    "build": "rollup -c",
+    "build": "rollup -c && yarn api-report",
     "build:deps": "lerna run --scope @firebase/app-compat --include-dependencies build",
     "dev": "rollup -c -w",
     "test": "run-p lint test:all",
     "test:all": "run-p test:browser test:node",
     "test:ci": "node ../../scripts/run_tests_in_ci.js -s test:all",
     "test:browser": "karma start --single-run",
     "test:browser:debug": "karma start --browsers Chrome --auto-watch",
-    "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha test/**/*.test.* src/**/*.test.ts --config ../../config/mocharc.node.js"
+    "test:node": "TS_NODE_FILES=true TS_NODE_CACHE=NO TS_NODE_COMPILER_OPTIONS='{\"module\":\"commonjs\"}' nyc --reporter lcovonly -- mocha test/**/*.test.* src/**/*.test.ts --config ../../config/mocharc.node.js",
+    "api-report": "api-extractor run --local --verbose",
+    "typings:public": "node ../../scripts/exp/use_typings.js ./dist/app-compat-public.d.ts"
   },
   "license": "Apache-2.0",
   "dependencies": {

packages/app-compat/src/firebaseApp.ts

@@ -59,6 +59,9 @@ export interface _FirebaseApp {
 /**
  * Global context object for a collection of services using
  * a shared authentication state.
+ * 
+ * marked as internal because it references internal types exported from @firebase/app
+ * @internal
  */
 export class FirebaseAppImpl implements Compat<_FirebaseAppExp>, _FirebaseApp {
   private container: ComponentContainer;

packages/app-compat/src/index.lite.ts

@@ -18,7 +18,7 @@
 import { createFirebaseNamespaceLite } from './lite/firebaseNamespaceLite';
 import { registerCoreComponents } from './registerCoreComponents';
 
-export const firebase = createFirebaseNamespaceLite();
+const firebase = createFirebaseNamespaceLite();
 
 registerCoreComponents('lite');
 

packages/app-compat/src/index.ts

@@ -39,7 +39,7 @@ if (isBrowser() && (self as any).firebase !== undefined) {
   }
 }
 
-export const firebase = firebaseNamespace;
+const firebase = firebaseNamespace;
 
 registerCoreComponents();
 

packages/app-compat/src/public-types.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 import { LogCallback, LogLevelString, LogOptions } from '@firebase/logger';
-import { FirebaseAppImpl, _FirebaseApp } from './firebaseApp';
+import { _FirebaseApp } from './firebaseApp';
 
 export interface FirebaseOptions {
   apiKey?: string;
@@ -31,6 +31,10 @@ export interface FirebaseOptions {
 export interface FirebaseAppConfig {
   name?: string;
   automaticDataCollectionEnabled?: boolean;
+}    
+
+interface FirebaseAppContructor {
+  new (): FirebaseApp;
 }
 
 /**
@@ -81,7 +85,7 @@ export interface FirebaseNamespace {
      *
      * DO NOT call this constuctor directly (use firebase.app() instead).
      */
-    App: typeof FirebaseAppImpl;
+    App: FirebaseAppContructor;
   };
 
   /**

packages/auth/cordova/demo/package.json

@@ -36,10 +36,10 @@
     ]
   },
   "dependencies": {
-    "@firebase/app": "0.0.900",
-    "@firebase/auth": "0.0.900",
+    "@firebase/app": "0.7.0",
+    "@firebase/auth": "0.17.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/util": "1.1.0",
+    "@firebase/util": "1.3.0",
     "cordova-plugin-browsertab": "0.2.0",
     "cordova-plugin-buildinfo": "4.0.0",
     "cordova-plugin-compat": "1.2.0",

packages/auth/demo/package.json

@@ -16,10 +16,10 @@
     "dev": "rollup -c -w"
   },
   "dependencies": {
-    "@firebase/app": "0.0.900",
-    "@firebase/auth": "0.0.900",
+    "@firebase/app": "0.7.0",
+    "@firebase/auth": "0.17.0",
     "@firebase/logger": "0.2.6",
-    "@firebase/util": "1.1.0",
+    "@firebase/util": "1.3.0",
     "tslib": "^2.1.0"
   },
   "license": "Apache-2.0",

packages/auth/package.json

@@ -41,7 +41,7 @@
     "test:node:integration": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --integration",
     "test:node:integration:local": "ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --integration --local",
     "test:webdriver": "rollup -c test/integration/webdriver/static/rollup.config.js && ts-node -O '{\"module\": \"commonjs\", \"target\": \"es6\"}' scripts/run_node_tests.ts --webdriver",
-    "api-report": "api-extractor run --local --verbose && ts-node-script ../../repo-scripts/prune-dts/prune-dts.ts --input dist/auth-public.d.ts --output dist/auth-public.d.ts",
+    "api-report": "api-extractor run --local --verbose",
     "doc": "api-documenter markdown --input temp --output docs",
     "build:doc": "yarn build && yarn doc",
     "typings:public": "node ../../scripts/exp/use_typings.js ./dist/auth-public.d.ts"