Skip to content

Commit 8481ee5

Browse files
Adding TODO to remove tryAcquirePrimaryLease
1 parent 2e10f8a commit 8481ee5

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

packages/firestore/src/local/indexeddb_persistence.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -302,7 +302,7 @@ export class IndexedDbPersistence implements Persistence {
302302
* Evaluate the state of all active instances and determine whether the local
303303
* client is or can act as the holder of the primary lease. Returns whether
304304
* the client is eligible for the lease, but does not actually acquire it.
305-
* May return 'false' even if there is no active leaseholder if another
305+
* May return 'false' even if there is no active leaseholder and another
306306
* (foreground) client should become leaseholder instead.
307307
*/
308308
private canActAsPrimary(

packages/firestore/test/unit/specs/spec_builder.ts

+2
Original file line numberDiff line numberDiff line change
@@ -252,6 +252,8 @@ export class SpecBuilder {
252252
return this;
253253
}
254254

255+
// TODO: Replace with .runTimer(TimerId.ClientStateRefresh) once #412 is
256+
// merged.
255257
tryAcquirePrimaryLease(): SpecBuilder {
256258
this.nextStep();
257259
this.currentStep = {

0 commit comments

Comments
 (0)