Address comments and add changeset

Author: zijianjoy

.changeset/modern-parents-worry.md

@@ -0,0 +1,6 @@
+---
+'@firebase/performance': patch
+'firebase': patch
+---
+
+Throws exception when startTime or duration is not positive value in `trace.record()` API.

packages-exp/performance-exp/src/utils/errors.ts

@@ -21,8 +21,8 @@ import { SERVICE, SERVICE_NAME } from '../constants';
 export const enum ErrorCode {
   TRACE_STARTED_BEFORE = 'trace started',
   TRACE_STOPPED_BEFORE = 'trace stopped',
-  NONPOSITIVE_TRACE_START_TIME = '',
-  NONPOSITIVE_TRACE_DURATION = '',
+  NONPOSITIVE_TRACE_START_TIME = 'nonpositive trace startTime',
+  NONPOSITIVE_TRACE_DURATION = 'nonpositive trace duration',
   NO_WINDOW = 'no window',
   NO_APP_ID = 'no app id',
   NO_PROJECT_ID = 'no project id',

packages/performance/src/utils/errors.ts

@@ -21,8 +21,8 @@ import { SERVICE, SERVICE_NAME } from '../constants';
 export const enum ErrorCode {
   TRACE_STARTED_BEFORE = 'trace started',
   TRACE_STOPPED_BEFORE = 'trace stopped',
-  NONPOSITIVE_TRACE_START_TIME = '',
-  NONPOSITIVE_TRACE_DURATION = '',
+  NONPOSITIVE_TRACE_START_TIME = 'nonpositive trace startTime',
+  NONPOSITIVE_TRACE_DURATION = 'nonpositive trace duration',
   NO_WINDOW = 'no window',
   NO_APP_ID = 'no app id',
   NO_PROJECT_ID = 'no project id',