Skip to content

Commit 80733ab

Browse files
author
Greg Soltis
committed
Merge branch 'master' into lru-master
2 parents eaeeb2a + a4ab0f6 commit 80733ab

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.github/CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
# Each line is a file pattern followed by one or more owners.
33

44
# These owners will be the default owners for everything in the repo.
5-
* @jshcrowthe @hiranya911 @mikelehen @bojeil-google @depoll
5+
* @Feiyang1 @hiranya911 @mikelehen @bojeil-google @depoll
66

77
# Database Code
88
packages/database @mikelehen @schmidt-sebastian

packages/functions/test/browser/callable.test.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import { HttpsError, FunctionsErrorCode } from '@firebase/functions-types';
2121
import firebase from '@firebase/app';
2222
import '@firebase/messaging';
2323
import { Service } from '../../src/api/service';
24+
import { isSupported } from '@firebase/messaging';
2425

2526
export const TEST_PROJECT = require('../../../../config/project.json');
2627

@@ -68,7 +69,7 @@ describe('Firebase Functions > Call', () => {
6869
// TODO(klimt): Move this to the cross-platform tests and delete this file,
6970
// once instance id works there.
7071
it('instance id', async () => {
71-
if (!('serviceWorker' in navigator)) {
72+
if (!isSupported()) {
7273
// Current platform does not support messaging, skip test.
7374
return;
7475
}

0 commit comments

Comments
 (0)