Skip to content

Commit 7d88c38

Browse files
ileowwjshcrowthe
authored andcommitted
Add @OverRide annotation to Promise methods that override Thenable's. (#57)
1 parent 26d3e4f commit 7d88c38

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

externs/firebase-app-externs.js

+2
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ firebase.Promise = function(resolver) {};
233233
* @param {(function(!Error): *)=} onReject Called when the Promise is rejected
234234
* (with an error).
235235
* @return {!firebase.Promise<*>}
236+
* @override
236237
*/
237238
firebase.Promise.prototype.then = function(onResolve, onReject) {};
238239

@@ -241,6 +242,7 @@ firebase.Promise.prototype.then = function(onResolve, onReject) {};
241242
*
242243
* @param {(function(!Error): *)=} onReject Called when the Promise is rejected
243244
* (with an error).
245+
* @override
244246
*/
245247
firebase.Promise.prototype.catch = function(onReject) {};
246248

src/database/js-client/firebase-app-externs.js

+2
Original file line numberDiff line numberDiff line change
@@ -182,6 +182,7 @@ firebase.Promise = function(resolver) {};
182182
* @param {(function(!Error): *)=} onReject Called when the Promise is rejected
183183
* (with an error).
184184
* @return {!firebase.Promise<*>}
185+
* @override
185186
*/
186187
firebase.Promise.prototype.then = function(onResolve, onReject) {};
187188

@@ -190,6 +191,7 @@ firebase.Promise.prototype.then = function(onResolve, onReject) {};
190191
*
191192
* @param {(function(!Error): *)=} onReject Called when the Promise is rejected
192193
* (with an error).
194+
* @override
193195
*/
194196
firebase.Promise.prototype.catch = function(onReject) {};
195197

0 commit comments

Comments
 (0)