Skip to content

Commit 7a889b9

Browse files
committed
Address PR comments
1 parent 3ff2ee3 commit 7a889b9

File tree

8 files changed

+14
-33
lines changed

8 files changed

+14
-33
lines changed

packages/database/exp/register.ts

+5-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,11 @@ export function registerDatabase(variant?: string): void {
3838
(container, { instanceIdentifier: url }) => {
3939
const app = container.getProvider('app-exp').getImmediate()!;
4040
const authProvider = container.getProvider('auth-internal');
41-
const appCheckProvider = container.getProvider('app-check-internal');
41+
// App check is unsupported in Node.
42+
const appCheckProvider =
43+
variant === 'node'
44+
? undefined
45+
: container.getProvider('app-check-internal');
4246
return repoManagerDatabaseFromApp(
4347
app,
4448
authProvider,

packages/database/index.node.ts

+6-2
Original file line numberDiff line numberDiff line change
@@ -86,10 +86,14 @@ export function registerDatabase(instance: FirebaseNamespace) {
8686
// getImmediate for FirebaseApp will always succeed
8787
const app = container.getProvider('app').getImmediate();
8888
const authProvider = container.getProvider('auth-internal');
89-
const appCheckProvider = container.getProvider('app-check-internal');
9089

9190
return new Database(
92-
repoManagerDatabaseFromApp(app, authProvider, appCheckProvider, url),
91+
repoManagerDatabaseFromApp(
92+
app,
93+
authProvider,
94+
/* appCheckProvider */ undefined,
95+
url
96+
),
9397
app
9498
);
9599
},

packages/database/test/browser/crawler_support.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ import { forceRestClient } from '../../src/api/test_access';
2121
import { getRandomNode, getFreshRepoFromReference } from '../helpers/util';
2222

2323
// Some sanity checks for the ReadonlyRestClient crawler support.
24-
describe.only('Crawler Support', () => {
24+
describe('Crawler Support', () => {
2525
let initialData;
2626
let normalRef;
2727
let restRef;

packages/firebase/app-check/index.ts

-18
This file was deleted.

packages/firebase/app-check/package.json

-7
This file was deleted.

packages/firebase/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,6 @@
8282
"messaging",
8383
"storage",
8484
"performance",
85-
"remote-config",
86-
"app-check"
85+
"remote-config"
8786
]
8887
}

packages/firebase/src/index.cdn.ts

-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@ import '../storage';
4040
import '../performance';
4141
import '../analytics';
4242
import '../remote-config';
43-
import '../app-check';
4443

4544
firebase.registerVersion(name, version, 'cdn');
4645

repo-scripts/prune-dts/tests/private-interface.input.d.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
declare interface A {
1919
a: string;
2020
}
21-
export class B implements A {
21+
export class B implements A{
2222
a: string;
2323
}
2424
export {};

0 commit comments

Comments
 (0)