Skip to content

Commit 75978dd

Browse files
committed
Remove the no-ios tag from bloom filter spec tests, now that the feature has been merged into the ios sdk in firebase/firebase-ios-sdk#11457
1 parent 59c7b58 commit 75978dd

File tree

3 files changed

+14
-28
lines changed

3 files changed

+14
-28
lines changed

packages/firestore/test/unit/specs/existence_filter_spec.test.ts

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,7 @@ describeSpec('Existence Filters:', [], () => {
277277
*/
278278
specTest(
279279
'Full re-query is skipped when bloom filter can identify documents deleted',
280-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
281-
['no-ios'],
280+
[],
282281
() => {
283282
const query1 = query('collection');
284283
const docA = doc('collection/a', 1000, { v: 1 });
@@ -310,8 +309,7 @@ describeSpec('Existence Filters:', [], () => {
310309

311310
specTest(
312311
'Full re-query is triggered when bloom filter can not identify documents deleted',
313-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
314-
['no-ios'],
312+
[],
315313
() => {
316314
const query1 = query('collection');
317315
const docA = doc('collection/a', 1000, { v: 1 });
@@ -343,8 +341,7 @@ describeSpec('Existence Filters:', [], () => {
343341

344342
specTest(
345343
'Bloom filter can process special characters in document name',
346-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
347-
['no-ios'],
344+
[],
348345
() => {
349346
const query1 = query('collection');
350347
const docA = doc('collection/ÀÒ∑', 1000, { v: 1 });
@@ -372,8 +369,7 @@ describeSpec('Existence Filters:', [], () => {
372369

373370
specTest(
374371
'Bloom filter fills in default values for undefined padding and hashCount',
375-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
376-
['no-ios'],
372+
[],
377373
() => {
378374
const query1 = query('collection');
379375
const docA = doc('collection/a', 1000, { v: 1 });
@@ -445,8 +441,7 @@ describeSpec('Existence Filters:', [], () => {
445441

446442
specTest(
447443
'Full re-query is triggered when bloom filter hashCount is invalid',
448-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
449-
['no-ios'],
444+
[],
450445
() => {
451446
const query1 = query('collection');
452447
const docA = doc('collection/a', 1000, { v: 1 });
@@ -480,8 +475,7 @@ describeSpec('Existence Filters:', [], () => {
480475

481476
specTest(
482477
'Full re-query is triggered when bloom filter is empty',
483-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
484-
['no-ios'],
478+
[],
485479
() => {
486480
const query1 = query('collection');
487481
const docA = doc('collection/a', 1000, { v: 1 });
@@ -516,8 +510,7 @@ describeSpec('Existence Filters:', [], () => {
516510

517511
specTest(
518512
'Same documents can have different bloom filters',
519-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
520-
['no-ios'],
513+
[],
521514
() => {
522515
const query1 = query('collection', filter('v', '<=', 2));
523516
const query2 = query('collection', filter('v', '>=', 2));
@@ -567,8 +560,7 @@ describeSpec('Existence Filters:', [], () => {
567560

568561
specTest(
569562
'Bloom filter is handled at global snapshot',
570-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
571-
['no-ios'],
563+
[],
572564
() => {
573565
const query1 = query('collection');
574566
const docA = doc('collection/a', 1000, { v: 1 });
@@ -600,8 +592,7 @@ describeSpec('Existence Filters:', [], () => {
600592

601593
specTest(
602594
'Bloom filter limbo resolution is denied',
603-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
604-
['no-ios'],
595+
[],
605596
() => {
606597
const query1 = query('collection');
607598
const docA = doc('collection/a', 1000, { v: 1 });
@@ -631,8 +622,7 @@ describeSpec('Existence Filters:', [], () => {
631622

632623
specTest(
633624
'Bloom filter with large size works as expected',
634-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
635-
['no-ios'],
625+
[],
636626
() => {
637627
const query1 = query('collection');
638628
const docs = [];

packages/firestore/test/unit/specs/limbo_spec.test.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -929,8 +929,7 @@ describeSpec('Limbo Documents:', [], () => {
929929

930930
specTest(
931931
'Limbo resolution throttling with bloom filter application',
932-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
933-
['no-ios'],
932+
[],
934933
() => {
935934
const query1 = query('collection');
936935
const docA1 = doc('collection/a1', 1000, { key: 'a1' });

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1812,8 +1812,7 @@ describeSpec('Listens:', [], () => {
18121812

18131813
specTest(
18141814
'Resuming a query should specify expectedCount when adding the target',
1815-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1816-
['no-ios'],
1815+
[],
18171816
() => {
18181817
const query1 = query('collection');
18191818
const docA = doc('collection/a', 1000, { key: 'a' });
@@ -1847,8 +1846,7 @@ describeSpec('Listens:', [], () => {
18471846

18481847
specTest(
18491848
'Resuming a query should specify expectedCount that does not include pending mutations',
1850-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1851-
['no-ios'],
1849+
[],
18521850
() => {
18531851
const query1 = query('collection');
18541852
const docA = doc('collection/a', 1000, { key: 'a' });
@@ -1877,8 +1875,7 @@ describeSpec('Listens:', [], () => {
18771875

18781876
specTest(
18791877
'ExpectedCount in listen request should work after coming back online',
1880-
// TODO(b/278759251) Remove 'no-ios' once bloom filter is merged.
1881-
['no-ios'],
1878+
[],
18821879
() => {
18831880
const query1 = query('collection');
18841881
const docA = doc('collection/a', 1000, { key: 'a' });

0 commit comments

Comments
 (0)