more tests

Author: fredzqm

packages/database/src/core/util/libs/parser.ts

@@ -171,7 +171,7 @@ export const parseDatabaseURL = function(
       secure = scheme === 'https' || scheme === 'wss';
       port = parseInt(host.substring(colonInd + 1), 10);
     } else {
-      colonInd = dataURL.length;
+      colonInd = host.length;
     }
 
     const hostWithoutPort = host.slice(0, colonInd);
@@ -181,8 +181,8 @@ export const parseDatabaseURL = function(
       domain = hostWithoutPort; // Domain is at least 2 parts.
     } else {
       const dotInd = host.indexOf('.');
-      domain = host.substring(dotInd + 1);
       subdomain = host.substring(0, dotInd).toLowerCase();
+      domain = host.substring(dotInd + 1);
       // Normalize namespaces to lowercase to share storage / connection.
       namespace = subdomain;
     }

packages/database/test/database.test.ts

@@ -71,12 +71,27 @@ describe('Database Tests', () => {
     );
   });
 
+  it('Can get database with upper case URL', () => {
+    const db = defaultApp.database('http://fOO.EUW1.firebaseDATABASE.app');
+    expect(db).to.be.ok;
+    expect(db.repo_.repoInfo_.namespace).to.equal('foo');
+    expect(db.ref().toString()).to.equal(
+      'https://foo.euw1.firebasedatabase.app/'
+    );
+  });
+
   it('Can get database with localhost URL and port', () => {
     const db = defaultApp.database('http://localhost:80');
     expect(db).to.be.ok;
     expect(db.ref().toString()).to.equal('http://localhost:80/');
   });
 
+  it('Can get database with a upper case localhost URL', () => {
+    const db = defaultApp.database('http://LOCALHOST');
+    expect(db).to.be.ok;
+    expect(db.ref().toString()).to.equal('https://localhost/');
+  });
+
   it('Can get database with localhost URL', () => {
     const db = defaultApp.database('http://localhost');
     expect(db).to.be.ok;
@@ -120,10 +135,19 @@ describe('Database Tests', () => {
     }).to.throw(/Database initialized multiple times/i);
   });
 
+  it('Databases with legacy domain', () => {
+    expect(() => {
+      defaultApp.database('http://foo.firebase.com/');
+    }).to.throw(/is no longer supported/i);
+  });
+
   it('Databases with invalid custom URLs', () => {
     expect(() => {
       defaultApp.database('not-a-url');
     }).to.throw(/Cannot parse Firebase url/i);
+    expect(() => {
+      defaultApp.database('http://foo.com');
+    }).to.throw(/Cannot parse Firebase url/i);
     expect(() => {
       defaultApp.database('http://fblocal.com');
     }).to.throw(/Cannot parse Firebase url/i);