Skip to content

Commit 744d337

Browse files
committed
resolve comments
1 parent b0b29a4 commit 744d337

File tree

1 file changed

+3
-11
lines changed

1 file changed

+3
-11
lines changed

packages/firestore/test/unit/specs/listen_spec.test.ts

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1811,7 +1811,7 @@ describeSpec('Listens:', [], () => {
18111811
);
18121812

18131813
specTest(
1814-
'Query with resume target can pass in expectedCount to listen request',
1814+
'Resuming a query should specify expectedCount when adding the target',
18151815
[],
18161816
() => {
18171817
const query1 = query('collection');
@@ -1845,7 +1845,7 @@ describeSpec('Listens:', [], () => {
18451845
);
18461846

18471847
specTest(
1848-
'ExpectedCount should equal to the number of documents that last matched the query at the resume token',
1848+
'Resuming a query should specify expectedCount that does not include pending mutations',
18491849
[],
18501850
() => {
18511851
const query1 = query('collection');
@@ -1879,22 +1879,14 @@ describeSpec('Listens:', [], () => {
18791879
() => {
18801880
const query1 = query('collection');
18811881
const docA = doc('collection/a', 1000, { key: 'a' });
1882-
const docBLocal = doc('collection/b', 1000, {
1883-
key: 'b'
1884-
}).setHasLocalMutations();
18851882

18861883
return spec()
18871884
.withGCEnabled(false)
18881885
.userListens(query1)
18891886
.watchAcksFull(query1, 1000, docA)
18901887
.expectEvents(query1, { added: [docA] })
1891-
.userSets('collection/b', { key: 'b' })
1892-
.expectEvents(query1, {
1893-
hasPendingWrites: true,
1894-
added: [docBLocal]
1895-
})
18961888
.disableNetwork()
1897-
.expectEvents(query1, { hasPendingWrites: true, fromCache: true })
1889+
.expectEvents(query1, { fromCache: true })
18981890
.enableNetwork()
18991891
.restoreListen(query1, 'resume-token-1000', 1);
19001892
}

0 commit comments

Comments
 (0)