Start updating files

Author: hsubox76

config/tsconfig.base.json

@@ -4,6 +4,7 @@
     "declaration": true,
     "importHelpers": true,
     "strictNullChecks": true,
+    "noImplicitAny": true,
     "lib": [
       "es2015",
       "dom"

packages/functions/index.node.ts

@@ -16,7 +16,7 @@
  */
 import firebase from '@firebase/app';
 import { FirebaseApp } from '@firebase/app-types';
-import { FirebaseServiceFactory } from '@firebase/app-types/private';
+import { FirebaseServiceFactory, _FirebaseNamespace } from '@firebase/app-types/private';
 import { Service } from './src/api/service';
 import 'isomorphic-fetch';
 
@@ -29,7 +29,7 @@ function factory(app: FirebaseApp, unused: any, region?: string): Service {
   return new Service(app, region);
 }
 
-export function registerFunctions(instance) {
+export function registerFunctions(instance: _FirebaseNamespace) {
   let namespaceExports = {
     // no-inline
     Functions: Service
@@ -45,4 +45,4 @@ export function registerFunctions(instance) {
   );
 }
 
-registerFunctions(firebase);
+registerFunctions(firebase as _FirebaseNamespace);

packages/functions/index.ts

@@ -16,7 +16,7 @@
  */
 import firebase from '@firebase/app';
 import * as app_types from '@firebase/app-types';
-import { FirebaseServiceFactory } from '@firebase/app-types/private';
+import { FirebaseServiceFactory, _FirebaseNamespace } from '@firebase/app-types/private';
 import * as types from '@firebase/functions-types';
 import { Service } from './src/api/service';
 
@@ -33,7 +33,7 @@ function factory(
   return new Service(app, region);
 }
 
-export function registerFunctions(instance) {
+export function registerFunctions(instance: _FirebaseNamespace) {
   let namespaceExports = {
     // no-inline
     Functions: Service
@@ -49,7 +49,7 @@ export function registerFunctions(instance) {
   );
 }
 
-registerFunctions(firebase);
+registerFunctions(firebase as _FirebaseNamespace);
 
 declare module '@firebase/app-types' {
   interface FirebaseNamespace {

packages/functions/src/serializer.ts

@@ -18,8 +18,8 @@
 const LONG_TYPE = 'type.googleapis.com/google.protobuf.Int64Value';
 const UNSIGNED_LONG_TYPE = 'type.googleapis.com/google.protobuf.UInt64Value';
 
-function mapValues(o: object, f: (any) => any): object {
-  let result = {};
+function mapValues(o: { [key: string]: any }, f: (arg0: any) => any): object {
+  let result: { [key: string]: any } = {};
   for (var key in o) {
     if (o.hasOwnProperty(key)) {
       result[key] = f(o[key]);

packages/logger/src/logger.ts

@@ -139,19 +139,19 @@ export class Logger {
    * The functions below are all based on the `console` interface
    */
 
-  debug(...args) {
+  debug(...args: any[]) {
     this._logHandler(this, LogLevel.DEBUG, ...args);
   }
-  log(...args) {
+  log(...args: any[]) {
     this._logHandler(this, LogLevel.VERBOSE, ...args);
   }
-  info(...args) {
+  info(...args: any[]) {
     this._logHandler(this, LogLevel.INFO, ...args);
   }
-  warn(...args) {
+  warn(...args: any[]) {
     this._logHandler(this, LogLevel.WARN, ...args);
   }
-  error(...args) {
+  error(...args: any[]) {
     this._logHandler(this, LogLevel.ERROR, ...args);
   }
 }

packages/storage/index.ts

@@ -17,7 +17,7 @@
 
 import firebase from '@firebase/app';
 import { FirebaseApp } from '@firebase/app-types';
-import { FirebaseServiceFactory } from '@firebase/app-types/private';
+import { FirebaseServiceFactory, _FirebaseNamespace } from '@firebase/app-types/private';
 import { StringFormat } from './src/implementation/string';
 import { TaskEvent } from './src/implementation/taskenums';
 import { TaskState } from './src/implementation/taskenums';
@@ -39,7 +39,7 @@ function factory(
   return new Service(app, new XhrIoPool(), opt_url) as any;
 }
 
-export function registerStorage(instance) {
+export function registerStorage(instance: _FirebaseNamespace) {
   let namespaceExports = {
     // no-inline
     TaskState: TaskState,
@@ -58,7 +58,7 @@ export function registerStorage(instance) {
   );
 }
 
-registerStorage(firebase);
+registerStorage(firebase as _FirebaseNamespace);
 
 /**
  * Define extension behavior for `registerStorage`

packages/storage/src/implementation/fs.ts

@@ -21,10 +21,6 @@
  */
 import * as type from './type';
 
-declare var IBlobBuilder;
-declare var BlobBuilder;
-declare var WebKitBlobBuilder;
-
 function getBlobBuilder(): (typeof IBlobBuilder) | undefined {
   if (typeof BlobBuilder !== 'undefined') {
     return BlobBuilder;

packages/storage/src/implementation/requests.ts

@@ -163,7 +163,7 @@ export function list(
   pageToken?: string | null,
   maxResults?: number | null
 ): RequestInfo<ListResult> {
-  let urlParams = {};
+  let urlParams: { [key: string]: any } = {};
   if (location.isRoot) {
     urlParams['prefix'] = '';
   } else {
@@ -427,13 +427,16 @@ export function getResumableUploadStatus(
 
   function handler(xhr: XhrIo, text: string): ResumableUploadStatus {
     let status = checkResumeHeader_(xhr, ['active', 'final']);
-    let sizeString;
+    let sizeString: string | null = null;
     try {
       sizeString = xhr.getResponseHeader('X-Goog-Upload-Size-Received');
+      if (sizeString === null) {
+        handlerCheck(false);
+      }
     } catch (e) {
       handlerCheck(false);
     }
-    let size = parseInt(sizeString, 10);
+    let size = parseInt(sizeString as string, 10);
     handlerCheck(!isNaN(size));
     return new ResumableUploadStatus(size, blob.size(), status === 'final');
   }

packages/util/src/assert.ts

@@ -19,21 +19,17 @@ import { CONSTANTS } from './constants';
 
 /**
  * Throws an error if the provided assertion is falsy
- * @param {*} assertion The assertion to be tested for falsiness
- * @param {!string} message The message to display if the check fails
  */
-export const assert = function(assertion, message) {
+export const assert = function(assertion: any, message: string) {
   if (!assertion) {
     throw assertionError(message);
   }
 };
 
 /**
  * Returns an Error object suitable for throwing.
- * @param {string} message
- * @return {!Error}
  */
-export const assertionError = function(message) {
+export const assertionError = function(message: string): Error {
   return new Error(
     'Firebase Database (' +
       CONSTANTS.SDK_VERSION +

packages/util/src/crypt.ts

@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 
-const stringToByteArray = function(str) {
+const stringToByteArray = function(str: string) {
   // TODO(user): Use native implementations if/when available
   var out: number[] = [],
     p = 0;
@@ -52,7 +52,7 @@ const stringToByteArray = function(str) {
  * @param bytes Array of numbers representing characters.
  * @return Stringification of the array.
  */
-const byteArrayToString = function(bytes) {
+const byteArrayToString = function(bytes: number[]) {
   // TODO(user): Use native implementations if/when available
   var out: string[] = [],
     pos = 0,

packages/util/src/deferred.ts

@@ -17,8 +17,8 @@
 
 export class Deferred<R> {
   promise: Promise<R>;
-  reject;
-  resolve;
+  reject: (value?: R | PromiseLike<R> | Error ) => void;
+  resolve: (value?: R | PromiseLike<R>) => void;
   constructor() {
     this.promise = new Promise((resolve, reject) => {
       this.resolve = resolve;
@@ -30,10 +30,8 @@ export class Deferred<R> {
    * Our API internals are not promiseified and cannot because our callback APIs have subtle expectations around
    * invoking promises inline, which Promises are forbidden to do. This method accepts an optional node-style callback
    * and returns a node-style callback which will resolve or reject the Deferred's promise.
-   * @param {((?function(?(Error)): (?|undefined))| (?function(?(Error),?=): (?|undefined)))=} callback
-   * @return {!function(?(Error), ?=)}
    */
-  wrapCallback(callback?) {
+  wrapCallback(callback?: (error?: Error, value?: any) => void): (error: Error, value?: any) => void {
     return (error, value?) => {
       if (error) {
         this.reject(error);

packages/util/src/environment.ts

@@ -42,6 +42,8 @@ export function getUA(): string {
 export function isMobileCordova(): boolean {
   return (
     typeof window !== 'undefined' &&
+    // @ts-ignore Setting up an broadly applicable index signature for Window
+    // just to deal with this case would probably be a bad idea.
     !!(window['cordova'] || window['phonegap'] || window['PhoneGap']) &&
     /ios|iphone|ipod|ipad|android|blackberry|iemobile/i.test(getUA())
   );

packages/util/src/json.ts

@@ -21,7 +21,7 @@
  * @param {string} str A string containing JSON.
  * @return {*} The javascript object representing the specified JSON.
  */
-export function jsonEval(str) {
+export function jsonEval(str: string): { [key: string]: any } {
   return JSON.parse(str);
 }
 
@@ -30,6 +30,6 @@ export function jsonEval(str) {
  * @param {*} data Javascript object to be stringified.
  * @return {string} The JSON contents of the object.
  */
-export function stringify(data) {
+export function stringify(data: any): string {
   return JSON.stringify(data);
 }

packages/util/src/jwt.ts

@@ -28,7 +28,7 @@ import { jsonEval } from './json';
  * @param {?string} token
  * @return {{header: *, claims: *, data: *, signature: string}}
  */
-export const decode = function(token) {
+export const decode = function(token: string): {} {
   var header = {},
     claims = {},
     data = {},