address some comments

hsubox76 · hsubox76 · commit 70cf8a7712fe · 2022-11-30T10:24:54.000-08:00
diff --git a/integration/compat-interop/package.json b/integration/compat-interop/package.json
@@ -26,4 +26,4 @@
   "devDependencies": {
     "typescript": "4.7.4"
   }
-}
+}
diff --git a/packages/performance/src/utils/attributes_utils.ts b/packages/performance/src/utils/attributes_utils.ts
@@ -45,6 +45,8 @@ const enum EffectiveConnectionType {
  * ref: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation
  */
 interface NetworkInformationWithEffectiveType extends NetworkInformation {
+  // `effectiveType` is an experimental property and not included in
+  // TypeScript's typings for the native NetworkInformation interface
   readonly effectiveType?: 'slow-2g' | '2g' | '3g' | '4g';
 }
 

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,8 @@ const enum EffectiveConnectionType {`
`45`	`45`	`* ref: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation`
`46`	`46`	`*/`
`47`	`47`	`interface NetworkInformationWithEffectiveType extends NetworkInformation {`
	`48`	+ // `effectiveType` is an experimental property and not included in
	`49`	`+ // TypeScript's typings for the native NetworkInformation interface`
`48`	`50`	`readonly effectiveType?: 'slow-2g' \| '2g' \| '3g' \| '4g';`
`49`	`51`	`}`
`50`	`52`