Skip to content

Commit 6ae16b7

Browse files
committed
Resolve review comments
1 parent 1bd3549 commit 6ae16b7

File tree

2 files changed

+8
-11
lines changed

2 files changed

+8
-11
lines changed

packages/auth/src/api/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export const enum EnforcementState {
9494
ENFORCEMENT_STATE_UNSPECIFIED = 'ENFORCEMENT_STATE_UNSPECIFIED'
9595
}
9696

97-
// Providers that has reCAPTCHA Enterprise support.
97+
// Providers that have reCAPTCHA Enterprise support.
9898
export const enum RecaptchaProvider {
9999
EMAIL_PASSWORD_PROVIDER = 'EMAIL_PASSWORD_PROVIDER'
100100
}

packages/auth/src/platform_browser/recaptcha/recaptcha.ts

+7-10
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ export class RecaptchaConfig {
8282
siteKey: string = '';
8383

8484
/**
85-
* The list of providers and their enablement status for reCAPTCHA.
85+
* The list of providers and their enablement status for reCAPTCHA Enterprise.
8686
*/
8787
recaptchaEnforcementStateList: RecaptchaEnforcementState[] = [];
8888

@@ -96,10 +96,10 @@ export class RecaptchaConfig {
9696
}
9797

9898
/**
99-
* Returns the reCAPTCHA enforcement state for the given provider.
99+
* Returns the reCAPTCHA Enterprise enforcement state for the given provider.
100100
*
101101
* @param providerStr - The provider whose enforcement state is to be returned.
102-
* @returns The reCAPTCHA enforcement state for the given provider.
102+
* @returns The reCAPTCHA Enterprise enforcement state for the given provider.
103103
*/
104104
getProviderEnforcementState(providerStr: string): EnforcementState | null {
105105
if (
@@ -124,19 +124,16 @@ export class RecaptchaConfig {
124124
}
125125

126126
/**
127-
* Returns true if the reCAPTCHA enforcement state for the provider is set to ENFORCE or AUDIT.
127+
* Returns true if the reCAPTCHA Enterprise enforcement state for the provider is set to ENFORCE or AUDIT.
128128
*
129129
* @param providerStr - The provider whose enablement state is to be returned.
130-
* @returns Whether or not reCAPTCHA protection is enabled for the given provider.
130+
* @returns Whether or not reCAPTCHA Enterprise protection is enabled for the given provider.
131131
*/
132132
isProviderEnabled(providerStr: string): boolean {
133-
if (
133+
return (
134134
this.getProviderEnforcementState(providerStr) ===
135135
EnforcementState.ENFORCE ||
136136
this.getProviderEnforcementState(providerStr) === EnforcementState.AUDIT
137-
) {
138-
return true;
139-
}
140-
return false;
137+
);
141138
}
142139
}

0 commit comments

Comments
 (0)