PR feedback

Author: sam-gc

common/api-review/auth-exp.api.md

@@ -128,101 +128,101 @@ export interface AuthError extends FirebaseError {
 
 // @public
 export const AuthErrorCodes: {
-    ADMIN_ONLY_OPERATION: string;
-    ARGUMENT_ERROR: string;
-    APP_NOT_AUTHORIZED: string;
-    APP_NOT_INSTALLED: string;
-    CAPTCHA_CHECK_FAILED: string;
-    CODE_EXPIRED: string;
-    CORDOVA_NOT_READY: string;
-    CORS_UNSUPPORTED: string;
-    CREDENTIAL_ALREADY_IN_USE: string;
-    CREDENTIAL_MISMATCH: string;
-    CREDENTIAL_TOO_OLD_LOGIN_AGAIN: string;
-    DEPENDENT_SDK_INIT_BEFORE_AUTH: string;
-    DYNAMIC_LINK_NOT_ACTIVATED: string;
-    EMAIL_CHANGE_NEEDS_VERIFICATION: string;
-    EMAIL_EXISTS: string;
-    EMULATOR_CONFIG_FAILED: string;
-    EXPIRED_OOB_CODE: string;
-    EXPIRED_POPUP_REQUEST: string;
-    INTERNAL_ERROR: string;
-    INVALID_API_KEY: string;
-    INVALID_APP_CREDENTIAL: string;
-    INVALID_APP_ID: string;
-    INVALID_AUTH: string;
-    INVALID_AUTH_EVENT: string;
-    INVALID_CERT_HASH: string;
-    INVALID_CODE: string;
-    INVALID_CONTINUE_URI: string;
-    INVALID_CORDOVA_CONFIGURATION: string;
-    INVALID_CUSTOM_TOKEN: string;
-    INVALID_DYNAMIC_LINK_DOMAIN: string;
-    INVALID_EMAIL: string;
-    INVALID_EMULATOR_SCHEME: string;
-    INVALID_IDP_RESPONSE: string;
-    INVALID_MESSAGE_PAYLOAD: string;
-    INVALID_MFA_SESSION: string;
-    INVALID_OAUTH_CLIENT_ID: string;
-    INVALID_OAUTH_PROVIDER: string;
-    INVALID_OOB_CODE: string;
-    INVALID_ORIGIN: string;
-    INVALID_PASSWORD: string;
-    INVALID_PERSISTENCE: string;
-    INVALID_PHONE_NUMBER: string;
-    INVALID_PROVIDER_ID: string;
-    INVALID_RECIPIENT_EMAIL: string;
-    INVALID_SENDER: string;
-    INVALID_SESSION_INFO: string;
-    INVALID_TENANT_ID: string;
-    MFA_INFO_NOT_FOUND: string;
-    MFA_REQUIRED: string;
-    MISSING_ANDROID_PACKAGE_NAME: string;
-    MISSING_APP_CREDENTIAL: string;
-    MISSING_AUTH_DOMAIN: string;
-    MISSING_CODE: string;
-    MISSING_CONTINUE_URI: string;
-    MISSING_IFRAME_START: string;
-    MISSING_IOS_BUNDLE_ID: string;
-    MISSING_OR_INVALID_NONCE: string;
-    MISSING_MFA_INFO: string;
-    MISSING_MFA_SESSION: string;
-    MISSING_PHONE_NUMBER: string;
-    MISSING_SESSION_INFO: string;
-    MODULE_DESTROYED: string;
-    NEED_CONFIRMATION: string;
-    NETWORK_REQUEST_FAILED: string;
-    NULL_USER: string;
-    NO_AUTH_EVENT: string;
-    NO_SUCH_PROVIDER: string;
-    OPERATION_NOT_ALLOWED: string;
-    OPERATION_NOT_SUPPORTED: string;
-    POPUP_BLOCKED: string;
-    POPUP_CLOSED_BY_USER: string;
-    PROVIDER_ALREADY_LINKED: string;
-    QUOTA_EXCEEDED: string;
-    REDIRECT_CANCELLED_BY_USER: string;
-    REDIRECT_OPERATION_PENDING: string;
-    REJECTED_CREDENTIAL: string;
-    SECOND_FACTOR_ALREADY_ENROLLED: string;
-    SECOND_FACTOR_LIMIT_EXCEEDED: string;
-    TENANT_ID_MISMATCH: string;
-    TIMEOUT: string;
-    TOKEN_EXPIRED: string;
-    TOO_MANY_ATTEMPTS_TRY_LATER: string;
-    UNAUTHORIZED_DOMAIN: string;
-    UNSUPPORTED_FIRST_FACTOR: string;
-    UNSUPPORTED_PERSISTENCE: string;
-    UNSUPPORTED_TENANT_OPERATION: string;
-    UNVERIFIED_EMAIL: string;
-    USER_CANCELLED: string;
-    USER_DELETED: string;
-    USER_DISABLED: string;
-    USER_MISMATCH: string;
-    USER_SIGNED_OUT: string;
-    WEAK_PASSWORD: string;
-    WEB_STORAGE_UNSUPPORTED: string;
-    ALREADY_INITIALIZED: string;
+    readonly ADMIN_ONLY_OPERATION: "auth/admin-restricted-operation";
+    readonly ARGUMENT_ERROR: "auth/argument-error";
+    readonly APP_NOT_AUTHORIZED: "auth/app-not-authorized";
+    readonly APP_NOT_INSTALLED: "auth/app-not-installed";
+    readonly CAPTCHA_CHECK_FAILED: "auth/captcha-check-failed";
+    readonly CODE_EXPIRED: "auth/code-expired";
+    readonly CORDOVA_NOT_READY: "auth/cordova-not-ready";
+    readonly CORS_UNSUPPORTED: "auth/cors-unsupported";
+    readonly CREDENTIAL_ALREADY_IN_USE: "auth/credential-already-in-use";
+    readonly CREDENTIAL_MISMATCH: "auth/custom-token-mismatch";
+    readonly CREDENTIAL_TOO_OLD_LOGIN_AGAIN: "auth/requires-recent-login";
+    readonly DEPENDENT_SDK_INIT_BEFORE_AUTH: "auth/dependent-sdk-initialized-before-auth";
+    readonly DYNAMIC_LINK_NOT_ACTIVATED: "auth/dynamic-link-not-activated";
+    readonly EMAIL_CHANGE_NEEDS_VERIFICATION: "auth/email-change-needs-verification";
+    readonly EMAIL_EXISTS: "auth/email-already-in-use";
+    readonly EMULATOR_CONFIG_FAILED: "auth/emulator-config-failed";
+    readonly EXPIRED_OOB_CODE: "auth/expired-action-code";
+    readonly EXPIRED_POPUP_REQUEST: "auth/cancelled-popup-request";
+    readonly INTERNAL_ERROR: "auth/internal-error";
+    readonly INVALID_API_KEY: "auth/invalid-api-key";
+    readonly INVALID_APP_CREDENTIAL: "auth/invalid-app-credential";
+    readonly INVALID_APP_ID: "auth/invalid-app-id";
+    readonly INVALID_AUTH: "auth/invalid-user-token";
+    readonly INVALID_AUTH_EVENT: "auth/invalid-auth-event";
+    readonly INVALID_CERT_HASH: "auth/invalid-cert-hash";
+    readonly INVALID_CODE: "auth/invalid-verification-code";
+    readonly INVALID_CONTINUE_URI: "auth/invalid-continue-uri";
+    readonly INVALID_CORDOVA_CONFIGURATION: "auth/invalid-cordova-configuration";
+    readonly INVALID_CUSTOM_TOKEN: "auth/invalid-custom-token";
+    readonly INVALID_DYNAMIC_LINK_DOMAIN: "auth/invalid-dynamic-link-domain";
+    readonly INVALID_EMAIL: "auth/invalid-email";
+    readonly INVALID_EMULATOR_SCHEME: "auth/invalid-emulator-scheme";
+    readonly INVALID_IDP_RESPONSE: "auth/invalid-credential";
+    readonly INVALID_MESSAGE_PAYLOAD: "auth/invalid-message-payload";
+    readonly INVALID_MFA_SESSION: "auth/invalid-multi-factor-session";
+    readonly INVALID_OAUTH_CLIENT_ID: "auth/invalid-oauth-client-id";
+    readonly INVALID_OAUTH_PROVIDER: "auth/invalid-oauth-provider";
+    readonly INVALID_OOB_CODE: "auth/invalid-action-code";
+    readonly INVALID_ORIGIN: "auth/unauthorized-domain";
+    readonly INVALID_PASSWORD: "auth/wrong-password";
+    readonly INVALID_PERSISTENCE: "auth/invalid-persistence-type";
+    readonly INVALID_PHONE_NUMBER: "auth/invalid-phone-number";
+    readonly INVALID_PROVIDER_ID: "auth/invalid-provider-id";
+    readonly INVALID_RECIPIENT_EMAIL: "auth/invalid-recipient-email";
+    readonly INVALID_SENDER: "auth/invalid-sender";
+    readonly INVALID_SESSION_INFO: "auth/invalid-verification-id";
+    readonly INVALID_TENANT_ID: "auth/invalid-tenant-id";
+    readonly MFA_INFO_NOT_FOUND: "auth/multi-factor-info-not-found";
+    readonly MFA_REQUIRED: "auth/multi-factor-auth-required";
+    readonly MISSING_ANDROID_PACKAGE_NAME: "auth/missing-android-pkg-name";
+    readonly MISSING_APP_CREDENTIAL: "auth/missing-app-credential";
+    readonly MISSING_AUTH_DOMAIN: "auth/auth-domain-config-required";
+    readonly MISSING_CODE: "auth/missing-verification-code";
+    readonly MISSING_CONTINUE_URI: "auth/missing-continue-uri";
+    readonly MISSING_IFRAME_START: "auth/missing-iframe-start";
+    readonly MISSING_IOS_BUNDLE_ID: "auth/missing-ios-bundle-id";
+    readonly MISSING_OR_INVALID_NONCE: "auth/missing-or-invalid-nonce";
+    readonly MISSING_MFA_INFO: "auth/missing-multi-factor-info";
+    readonly MISSING_MFA_SESSION: "auth/missing-multi-factor-session";
+    readonly MISSING_PHONE_NUMBER: "auth/missing-phone-number";
+    readonly MISSING_SESSION_INFO: "auth/missing-verification-id";
+    readonly MODULE_DESTROYED: "auth/app-deleted";
+    readonly NEED_CONFIRMATION: "auth/account-exists-with-different-credential";
+    readonly NETWORK_REQUEST_FAILED: "auth/network-request-failed";
+    readonly NULL_USER: "auth/null-user";
+    readonly NO_AUTH_EVENT: "auth/no-auth-event";
+    readonly NO_SUCH_PROVIDER: "auth/no-such-provider";
+    readonly OPERATION_NOT_ALLOWED: "auth/operation-not-allowed";
+    readonly OPERATION_NOT_SUPPORTED: "auth/operation-not-supported-in-this-environment";
+    readonly POPUP_BLOCKED: "auth/popup-blocked";
+    readonly POPUP_CLOSED_BY_USER: "auth/popup-closed-by-user";
+    readonly PROVIDER_ALREADY_LINKED: "auth/provider-already-linked";
+    readonly QUOTA_EXCEEDED: "auth/quota-exceeded";
+    readonly REDIRECT_CANCELLED_BY_USER: "auth/redirect-cancelled-by-user";
+    readonly REDIRECT_OPERATION_PENDING: "auth/redirect-operation-pending";
+    readonly REJECTED_CREDENTIAL: "auth/rejected-credential";
+    readonly SECOND_FACTOR_ALREADY_ENROLLED: "auth/second-factor-already-in-use";
+    readonly SECOND_FACTOR_LIMIT_EXCEEDED: "auth/maximum-second-factor-count-exceeded";
+    readonly TENANT_ID_MISMATCH: "auth/tenant-id-mismatch";
+    readonly TIMEOUT: "auth/timeout";
+    readonly TOKEN_EXPIRED: "auth/user-token-expired";
+    readonly TOO_MANY_ATTEMPTS_TRY_LATER: "auth/too-many-requests";
+    readonly UNAUTHORIZED_DOMAIN: "auth/unauthorized-continue-uri";
+    readonly UNSUPPORTED_FIRST_FACTOR: "auth/unsupported-first-factor";
+    readonly UNSUPPORTED_PERSISTENCE: "auth/unsupported-persistence-type";
+    readonly UNSUPPORTED_TENANT_OPERATION: "auth/unsupported-tenant-operation";
+    readonly UNVERIFIED_EMAIL: "auth/unverified-email";
+    readonly USER_CANCELLED: "auth/user-cancelled";
+    readonly USER_DELETED: "auth/user-not-found";
+    readonly USER_DISABLED: "auth/user-disabled";
+    readonly USER_MISMATCH: "auth/user-mismatch";
+    readonly USER_SIGNED_OUT: "auth/user-signed-out";
+    readonly WEAK_PASSWORD: "auth/weak-password";
+    readonly WEB_STORAGE_UNSUPPORTED: "auth/web-storage-unsupported";
+    readonly ALREADY_INITIALIZED: "auth/already-initialized";
 };
 
 // @public

packages-exp/auth-exp/src/core/errors.ts

@@ -539,4 +539,4 @@ export const AUTH_ERROR_CODES_MAP_DO_NOT_USE_INTERNALLY = {
   WEAK_PASSWORD: 'auth/weak-password',
   WEB_STORAGE_UNSUPPORTED: 'auth/web-storage-unsupported',
   ALREADY_INITIALIZED: 'auth/already-initialized'
-};
+} as const;